fix: combine multiple --project filters correctly - #10988
Merged
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10491
matchesProjectFilterOR-combined every pattern, so--project=!a --project=!bexcluded nothing: each project satisfied the other negation. A negated pattern also degraded mixed filters,--project=foo --project=!barkept every project exceptbar.A project now runs if it matches no negated pattern and, when regular patterns are also given, matches at least one of them. The same rule applies to browser instances, so a negation can drop a single instance even when its parent project matches the filter.
The negation branch in
wildcardPatternToRegExpis removed: exclusions are checked separately now, so no caller passes a!-prefixed pattern anymore.