Skip to content

Add tsgolint to bin #1800

Closed

Description

@mo36924

Description

When you install vite-plus in a project with pnpm (pnpm i -D vite-plus), oxfmt, oxlint, and vp are installed as binaries.
oxlint-tsgolint is installed as a dependency of vite-plus, but not as a binary (tsgolint).

vp check (typeAware: true) can be executed successfully, but the following error occurs with the oxc-vscode extension.

WARN oxlint::lsp::server_linter: Failed to initialize type-aware linting: Failed to find tsgolint executable. You may need to add the `oxlint-tsgolint` package to your project?

Suggested solution

If you install oxlint-tsgolint, the warning will disappear, but I would like to match the version of oxlint-tsgolint used with vite-plus.
How about adding a wrapper script like oxfmt or oxlint and adding tsgolint to the bin field?

"bin": {
"oxfmt": "./bin/oxfmt",
"oxlint": "./bin/oxlint",
"vp": "./bin/vp"
},

Related PR
#629

Alternative

No response

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Confirm this request is for Vite+ itself and not for Vite, Vitest, tsdown, Rolldown, or Oxc.
  • Check that there isn't already an issue requesting the same feature.

Activity

  1. added theissue type on Jun 10, 2026
  2. fengmk2 commented on Jun 10, 2026

    @fengmk2
    Member

    The oxlint wrapper should find the right tsgolint bin from vite-plus, I'll look into it.

  3. self-assigned this
    on Jun 10, 2026
  4. added
    bugSomething isn't working
    and removed on Jun 10, 2026
  5. added this to the Beta milestone on Jun 10, 2026
  6. removed their assignment
    on Jun 10, 2026
  7. mo36924 commented on Jun 10, 2026

    @mo36924
    Author

    It may be found from oxlint but not from vscode-oxc.
    The node_modules/.bin/ directory contains oxfmt, oxlint, I only have vp

  8. self-assigned this
    on Jun 10, 2026
  9. jong-kyung commented on Jun 10, 2026

    @jong-kyung
    Collaborator

    @mo36924 I tried to reproduce this by creating a Vite application with vp create and checking whether the reported warning appears in VS Code with oxc-vscode, but I couldn’t reproduce it locally.

    Could you provide a minimal reproduction repository or exact reproduction steps?

    cc. @fengmk2

  10. mo36924 commented on Jun 10, 2026

    @mo36924
    Author

    Thank you for your reply.

    I also tried the same method (vp create) but no warning was displayed. But after removing node_modules, when I ran vp install and restarted vscode, I got a warning.
    Warning will be displayed if node_modules/.bin/tsgolint does not exist.
    If the lock file (pnpm-lock.yaml) is missing, the transitive dependency tsgolint appears to be installed in the node_modules/.bin directory.
    As a result, the warning will not be displayed correctly immediately after vp create, but after that, if you run vp install when node_modules is not present, a warning will be displayed.

    Minimal steps to reproduce.
    package.json

    {
      "devDependencies": {
        "vite-plus": "0.1.24"
      },
      "packageManager": "pnpm@11.5.3"
    }

    pnpm-workspace.yaml

    # empty file

    Place the above two files in an empty directory and run the following command.

    vp install
    # At this point node_modules/.bin/tsgolint exists.
    rm -rf node_modules
    vp install
    # At this point, node_modules/.bin/tsgolint does not exist.

    Related issues and PR
    #629
    #633

  11. jong-kyung commented on Jun 11, 2026

    @jong-kyung
    Collaborator

    @mo36924 Thanks for the detailed reproduction steps!

    I was able to reproduce the issue. After reinstalling from the existing lockfile, node_modules/.bin/tsgolint is missing, which causes oxc-vscode to fail type-aware linting discovery.

    I’ll prepare a PR to fix this by exposing a tsgolint wrapper from Vite+.

  12. added a commit that references this issue on Jun 11, 2026
    8271eaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Fields

Priority

None yet

Start date

None yet

Target date

None yet

Effort

None yet

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions