Skip to content

Stop using the "incumbent settings object" #60

Closed

Description

@Ms2ger

See whatwg/html#1430 for background.

Activity

  1. self-assigned this
    on Jan 31, 2017
  2. Ms2ger commented on Feb 1, 2017

    @Ms2ger
    ContributorAuthor

    Probably uses current global in Gecko

  3. domenic commented on Feb 4, 2017

    @domenic
    Contributor

    I've written some (quite fun...) tests which confirm that current seems more correct: web-platform-tests/wpt#4722

    @mkruisselbrink can I hand this over to you for test review + spec fixing?

  4. mkruisselbrink commented on Feb 6, 2017

    @mkruisselbrink
    Collaborator

    Thanks, had a look at the tests. Also played around a bit more with it. Edge seems to indeed (incorrectly) not serialize the origin in the URL. But it's still possibly to tease out what origin it associates with the blob URL by trying to XHR the resulting URL. And with that it seems that only an XMLHttpRequest instance created using the top (web-platform.test:8000) origin is able to read the blob. So at least edge isn't using the current settings object, but other than that the various settings objects always confuse me. Is that actually the incumbent settings object, or is that entry settings object? Either way it still seems reasonable to change the spec to "current" settings object.

  5. domenic commented on Feb 7, 2017

    @domenic
    Contributor

    Very interesting. Maybe you could submit extra tests so that we test both the serialization and XHR's ability to access. But yes, I agree we should go ahead with changing the spec and merging the tests.

  6. domenic commented on Feb 7, 2017

    @domenic
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions