You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
PresentationConnection.url should be optional? #325
The algorithm steps for creating a PresentationConnection set the url attribute after construction. It seems like we should make the attribute optional (like id) since it is not set in the constructor.
Alternatively, we could define a constructor that takes the url and id and modify the algorithms to use that; which seems better, since the API is not intended is to expose PresentationConnections without these properties set.
Reviewing the spec, in all cases where the user agent instantiates a PresentationConnection, it sets both the URL and the ID before returning it to the caller. So it makes more sense to make both PresentationConnection.id and PresentationConnection.url mandatory.
Activity
markafoltz commentedon Jul 13, 2016
Three algorithms that create PresentationConnection objects and set attributes after construction:
Alternatively, we could define a constructor that takes the url and id and modify the algorithms to use that; which seems better, since the API is not intended is to expose PresentationConnections without these properties set.
markafoltz commentedon Aug 18, 2016
Reviewing the spec, in all cases where the user agent instantiates a PresentationConnection, it sets both the URL and the ID before returning it to the caller. So it makes more sense to make both
PresentationConnection.idandPresentationConnection.urlmandatory.