Skip to content

setConnection in example 5.5 may put UI in an inconsistent state #339

Closed
Closed
setConnection in example 5.5 may put UI in an inconsistent state#339
Labels
P3v1

Description

@markafoltz
markafoltz
opened on Sep 16, 2016

setConnection() calls close() on an existing connection before adding an onconnect handler to the new connection. If the close event on the old connection fires after the connect event on the new connection, reset() will null out the new connection and disable the stop and disconnect buttons.

Activity

  1. markafoltz
    added
    P3
    on Sep 16, 2016
  2. anssiko
    added
    v1
    on Sep 22, 2016

  3. tidoust commented on Sep 26, 2016

    @tidoust
    tidoust
    on Sep 26, 2016
    Member

    See discussion at TPAC

    ACTION: @kenchris to review and fix the example in 5.5

  4. kenchris commented on Sep 30, 2016

    @kenchris
    kenchris
    on Sep 30, 2016
    Contributor

    #358

  5. markafoltz commented on Nov 16, 2016

    @markafoltz
    markafoltz
    on Nov 16, 2016
    ContributorAuthor

    Closing with the fixes in the PR.

  6. markafoltz
    closed this as completedon Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3v1

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions