Skip to content

Addresses Issue 367 - #395

Merged
markafoltz merged 3 commits into
gh-pagesfrom
issue-387-receiving-contexts
Dec 20, 2016
Merged

markafoltz merged 3 commits into
gh-pagesfrom
issue-387-receiving-contexts

Conversation

@markafoltz

@markafoltz markafoltz commented Dec 19, 2016 •

Copy link
Copy Markdown
Contributor

Addresses Issue #367: Well defined environment for nested contexts of the receiving browsing context?

This applies the restrictions placed on the receiving browsing context to child browsing contexts of that context. It also clarifies that navigator.presentation.receiver should be null in those contexts.

Please check my terminology :)

@tidoust tidoust left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this rather addresses issue #367, not issue #387.

See inline for a couple of minor comments. LGTM otherwise.

Comment thread index.html Outdated
"https://www.w3.org/TR/html5/browsers.html#nested-browsing-contexts">nested
browsing context</a></dfn>, and <dfn><a href=
"https://www.w3.org/TR/html51/browsers.html#list-of-the-descendant-browsing-contexts">
list of descendent browsing contexts</a></dfn>, and <dfn><a href=

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/descendent/descendant
(same typo to fix in the algorithm that references that notion)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment thread index.html Outdated
contexts</a> <a data-lt=
"creating a new browsing context">created</a> by the presented
document, i.e. that have the <a>receiving browsing context</a> as
their <a data-lt="ancestor browsing context">top-level

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the definition of top-level browsing context in HTML, I believe you can simply say "their top-level browsing context" here and drop the reference to "ancestor browsing context" (and drop it from the list of terms too).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@markafoltz markafoltz changed the title Addreses Issue 387 Addresses Issue 387 Dec 20, 2016
@markafoltz
markafoltz merged commit f2f4fee into gh-pages Dec 20, 2016
@markafoltz markafoltz changed the title Addresses Issue 387 Addresses Issue 367 Dec 20, 2016
@markafoltz
markafoltz deleted the issue-387-receiving-contexts branch December 20, 2016 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants