Skip to content

feat(core)!: use modern-module externals type for ESM - #1672

Merged
Timeless0911 merged 5 commits into
mainfrom
david/modern-module-externals
Jul 18, 2026
Merged

feat(core)!: use modern-module externals type for ESM#1672
Timeless0911 merged 5 commits into
mainfrom
david/modern-module-externals

Conversation

@Timeless0911

@Timeless0911 Timeless0911 commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

This PR changes the default ESM externalsType to Rspack's modern-module for all output targets. Static import externals remain ESM imports, dynamic import() externals remain dynamic, and CommonJS require() externals use createRequire for Node-like targets or a bare require() for other targets.

It also removes the legacy CommonJS external warning path and the no-longer-needed autoCjsNodeBuiltin RslibPlugin option.

When external modules loaded through createRequire() are bundled again, the consuming bundler must statically analyze this call pattern; Rspack supports it through module.parser.javascript.createRequire.

Related Links

https://rspack.rs/config/externals#externalstypemodern-module
https://rspack.rs/config/module-parser#javascriptcreaterequire

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings May 26, 2026 12:08
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying rslib with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5c23ae2
Status: ✅  Deploy successful!
Preview URL: https://f70bc5d9.rslib.pages.dev
Branch Preview URL: https://david-modern-module-external.rslib.pages.dev

View logs

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 26, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87ff22e106

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/core/src/config.ts
Copilot AI reviewed May 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Timeless0911
Timeless0911 requested a review from Copilot May 27, 2026 03:10
Copilot AI reviewed May 27, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@Timeless0911 Timeless0911 changed the title feat(core): use modern-module externals type for esm feat(core): use modern-module externals type for Node ESM May 27, 2026
@Timeless0911
Timeless0911 force-pushed the david/modern-module-externals branch from bcf4bbe to 28f0e83 Compare May 28, 2026 08:58
@Timeless0911

Timeless0911 commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

pending

  1. Rspack support bundle createRequire
  2. modern-module external type now depends externalsPreset.node to determine node target, but Rslib set externalsPreset.node to false since fix: remove externalsPresets.node #1318 due to externals: { fs: false } can not takes effect with externalsPreset which should be a bug of Rspack externals?

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 29, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7baca3eb91

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/core/src/config.ts
@Timeless0911 Timeless0911 changed the title feat(core): use modern-module externals type for Node ESM feat(core)!: use modern-module externals type for Node ESM Jul 18, 2026
@Timeless0911
Timeless0911 force-pushed the david/modern-module-externals branch from 7baca3e to 5c23ae2 Compare July 18, 2026 07:38
@Timeless0911 Timeless0911 changed the title feat(core)!: use modern-module externals type for Node ESM feat(core)!: use modern-module externals type for ESM Jul 18, 2026
@Timeless0911
Timeless0911 merged commit 93ca93e into main Jul 18, 2026
12 checks passed
@Timeless0911
Timeless0911 deleted the david/modern-module-externals branch July 18, 2026 07:53
@Timeless0911 Timeless0911 mentioned this pull request Jul 23, 2026
Merged
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Timeless0911
Sponsor
SponsoredKunjungi sekarang
Promo