refactor(core): replace tsconfck with get-tsconfig - #1757
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates @rslib/core’s tsconfig loading to replace the unmaintained tsconfck dependency with get-tsconfig, aligning tsconfig resolution with the approach used elsewhere in the ecosystem and reducing reliance on deprecated tooling.
Changes:
- Replace
tsconfck-basedfind/parsewithget-tsconfig(readTsconfig) loaded dynamically when a tsconfig file exists. - Update unit tests for the new tsconfig parsing output shape.
- Update dependencies/lockfile and clean up spellcheck dictionary entries.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/dictionary.txt | Removes the tsconfck word entry now that the dependency is gone. |
| pnpm-lock.yaml | Swaps tsconfck out and locks get-tsconfig@5.0.0-beta.5 for @rslib/core. |
| packages/core/tests/tsconfig.test.ts | Updates assertions for the new tsconfig loader behavior/output. |
| packages/core/src/utils/tsconfig.ts | Reimplements loadTsconfig using get-tsconfig with conditional dynamic import. |
| packages/core/package.json | Replaces tsconfck dependency with get-tsconfig. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
50b0f11 to
87b61ed
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87b61edb3d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d3cd3be to
6b5f53a
Compare
6b5f53a to
1adee33
Compare
Summary
Replace
tsconfckin@rslib/corewithget-tsconfigbecausetsconfckis unmaintained. Rslib now resolvessource.tsconfigPaththe same way Rsbuild does, loadsget-tsconfigdynamically only when a tsconfig file exists, and opts out of TypeScript-version defaults to preserve the existing compiler options behavior.Related Links
https://github.com/dominikg/tsconfck/issues/240
Checklist