feat(dts)!: enable declaration extension redirects by default - #1784
Merged
Merged
Conversation
BREAKING CHANGE: Declaration import paths now use runtime JavaScript extensions by default. Set `redirect.dts.extension` to `false` to preserve existing specifiers.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 530dc8947a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables redirect.dts.extension by default so generated declaration files prefer explicit runtime JavaScript extensions (e.g. .js, .mjs) without requiring extra configuration, aligning better with Node16/NodeNext-style resolution.
Changes:
- Switch the default for declaration extension redirection from
falsetotrueacross core/plugin defaults and type docs. - Update integration tests and snapshots to expect redirected
.jsspecifiers by default, and adjust the explicit “extension: false” cases accordingly. - Expand the redirect docs (EN/ZH) with caveats for
paths/dts.aliaspath mapping and ESM/CJS declaration interop.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/config/lib/redirect.mdx | Update default to true and add caveats/notes for redirect.dts.extension. |
| website/docs/en/config/lib/redirect.mdx | Update default to true and add caveats/notes for redirect.dts.extension. |
| tests/integration/redirect/dtsTsgo.test.ts | Update snapshots and test naming to reflect extension redirect being enabled by default (tsgo). |
| tests/integration/redirect/dtsIsolated.test.ts | Update snapshots and test naming to reflect extension redirect being enabled by default (isolated). |
| tests/integration/redirect/dts/rslib.isolated.config.mts | Adjust test matrix configs/dist paths to match new default and the explicit extension: false variant. |
| tests/integration/redirect/dts/rslib.config.mts | Adjust test matrix configs/dist paths to match new default and the explicit extension: false variant. |
| tests/integration/redirect/dts.test.ts | Update snapshots and test naming to reflect extension redirect being enabled by default. |
| tests/integration/redirect/dts-tsgo/rslib.config.mts | Adjust tsgo redirect configs/dist paths for the updated default behavior. |
| tests/integration/dts/isolated/index.test.ts | Update assertions to expect .js specifiers in generated declarations. |
| tests/integration/dts/composite/index.test.ts | Update snapshots to expect .js extensions in re-export specifiers. |
| tests/integration/dts/bundle-false/index.test.ts | Update snapshots to expect .js extensions in rewritten declaration specifiers. |
| tests/integration/dts/bundle-false/snapshots/index.test.ts.snap | Update stored snapshots for .js extension redirects. |
| tests/integration/dts-tsgo/bundle-false/index.test.ts | Update snapshots to expect .js extensions in rewritten declaration specifiers (tsgo). |
| tests/integration/dts-tsgo/bundle-false/snapshots/index.test.ts.snap | Update stored snapshots for .js extension redirects (tsgo). |
| packages/plugin-dts/src/isolated.ts | Change default redirect behavior for isolated DTS post-processing to enable extension redirects. |
| packages/plugin-dts/src/index.ts | Change plugin option default redirect.extension to true. |
| packages/plugin-dts/src/dts.ts | Change DTS generation default redirect behavior to enable extension redirects. |
| packages/plugin-dts/README.md | Update README defaults/docs to reflect extension redirects enabled by default. |
| packages/core/src/types/config.ts | Update redirect.dts.extension documented default to true. |
Deploying rslib with
|
| Latest commit: |
72a53c5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4509554c.rslib.pages.dev |
| Branch Preview URL: | https://david-feat-dts-extension-def.rslib.pages.dev |
fi3ework
approved these changes
Jul 22, 2026
This was referenced Jul 23, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redirect.dts.extensionby default so declaration imports use runtime JavaScript extensions without extra configuration.redirect.dts.extensiontofalseto preserve the previous behavior.Related Links
Closes #1733
Checklist