feat(deps): update Rsbuild to v2.1.10 - #1826
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The dependency bump is a small patch update and the accompanying integration test changes directly validate the new addon-loading behavior without introducing risky logic changes.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR updates the workspace-pinned @rsbuild/core version to ~2.1.10 (including create-rslib Storybook templates) and adjusts integration coverage around Node.js addon loading behavior introduced upstream (Rsbuild #8203).
Changes:
- Bump
@rsbuild/corefrom~2.1.9to~2.1.10in the workspace catalog and Storybook templates. - Update the Node.js addons integration test to assert the new ESM loader behavior and to runtime-import ESM outputs on Darwin arm64.
- Regenerate/deduplicate
pnpm-lock.yamlto reflect the updated dependency graph (including@rspack/*and related transitive updates).
File summaries
| File | Description |
|---|---|
| tests/integration/asset/index.test.ts | Extends addon-loader assertions (e.g., fileURLToPath) and adds Darwin arm64 runtime imports for ESM bundle/bundleless outputs. |
| pnpm-workspace.yaml | Updates the workspace catalog pin for @rsbuild/core to ~2.1.10. |
| pnpm-lock.yaml | Lockfile refresh to incorporate @rsbuild/core@2.1.10 and updated transitive resolutions. |
| packages/create-rslib/template-storybook/vue-ts/package.json | Updates template devDependency pin for @rsbuild/core to ~2.1.10. |
| packages/create-rslib/template-storybook/vue-js/package.json | Updates template devDependency pin for @rsbuild/core to ~2.1.10. |
| packages/create-rslib/template-storybook/react-ts/package.json | Updates template devDependency pin for @rsbuild/core to ~2.1.10. |
| packages/create-rslib/template-storybook/react-js/package.json | Updates template devDependency pin for @rsbuild/core to ~2.1.10. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
- Files reviewed: 6/7 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
@rsbuild/coreto v2.1.10 across the workspace and Storybook templates, pulling in the environment-aware Node.js addon loader from Rsbuild #8203. It also exercises both bundled and bundleless ESM addon outputs at runtime on Darwin arm64 and deduplicates the lockfile.Related Links
Checklist