docs: add wasm version metadata - #1922
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved localization, release-link, and anchor findings must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds reusable version metadata to WASM documentation and records lib.wasm: false history in English and Chinese.
Changes:
- Adds and styles the
ApiMetacomponent. - Annotates WASM guides with version metadata.
- Adds
lib.wasmversion-history tables.
File summaries
| File | Reviewed change | Findings |
|---|---|---|
website/theme/components/ApiMeta.tsx |
Reusable version metadata component | Moderate (3 votes): labels are not localized. Moderate (1 vote): v1.0.1 release link currently leads to a 404. |
website/theme/components/ApiMeta.module.scss |
Metadata badge styling | No additional findings. |
website/docs/zh/guide/advanced/wasm.mdx |
Chinese WASM guide annotation | No additional findings. |
website/docs/zh/config/lib/wasm.mdx |
Chinese version history | Nit (2 votes): align the localized heading anchor with the English anchor. |
website/docs/en/guide/advanced/wasm.mdx |
English WASM guide annotation | No additional findings. |
website/docs/en/config/lib/wasm.mdx |
English version history | No additional findings. |
Review details
Suppressed comments (1)
website/theme/components/ApiMeta.tsx:21
- This renders the added-version badge as a link to
v1.0.1, but that release/tag does not currently exist inweb-infra-dev/rslib(the release list currently ends atv1.0.0), so the badge leads to a 404 page. Link to an existing release or make the link conditional untilv1.0.1is published.
<Link href={getGitTagHref(props.addedVersion)}>
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Deploying rslib with
|
| Latest commit: |
1a44416
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6f7653a3.rslib.pages.dev |
| Branch Preview URL: | https://docs-wasm-version-history.rslib.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Document when disabling
.wasmmodule handling became available and make the version visible in the relevant guide section.Changes
ApiMetacomponent based on the Rstest implementation.lib.wasm: falseas added in v1.0.1 in the advanced Wasm guide.lib.wasmconfiguration documentation.