chore: flatten package Rslib configs - #1938
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified, and all reviewed changes are approval-ready.
Review effort: Lite
Findings: None
What changed in this PR
Flattens the Rslib configurations for the core and plugin-dts packages while preserving declaration and ESM shim behavior.
Changes:
- Moves
dtssettings to the top level. - Moves the required ESM
requireshim to the top level in plugin-dts.
| File | Description |
|---|---|
packages/core/rslib.config.ts |
Flattens declaration configuration. |
packages/plugin-dts/rslib.config.ts |
Flattens declaration and shim configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The core and dts packages each define a single
libitem solely to hold options that Rslib also supports at the top level. Removing the wrapper simplifies these package configs.Changes
Move the declaration settings to top-level
dtsin both packages and keepshims.esm.requireat the top level for dts. The shim is still needed by bundledtsconfig-paths: disabling it causesrequire is not definedat runtime. Builds and lint pass, and the before/after output files are byte-for-byte identical.