chore(dts): remove NO_COLOR workaround for Rstest - #1943
Conversation
Rstest no longer injects FORCE_COLOR into test workers since @rstest/core 0.12.2, so plugin-dts tests no longer need to disable colors. Refresh the lockfile to @rstest/core 0.12.2.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Keep the catalog in sync with the lockfile, which already resolves 0.12.2.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The lockfile catalog specifiers must remain aligned with pnpm-workspace.yaml.
Review effort: Lite
Findings: 1
What changed in this PR
Updates Rstest to 0.12.2 and removes the obsolete NO_COLOR workaround from plugin-dts tests.
Changes:
- Removes the
NO_COLORoverride. - Refreshes locked Rstest package versions.
- Retains lockfile catalog specifiers aligned with
pnpm-workspace.yaml.
| File | Summary |
|---|---|
pnpm-lock.yaml |
Updates Rstest resolutions; catalog specifiers must remain ^0.12.0. |
packages/plugin-dts/rstest.config.ts |
Removes the obsolete color workaround. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03a4a4ea06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Motivation
Rstest used to inject
FORCE_COLOR=1into test worker processes (on a TTY or withCI=true), soprettyTimein plugin-dts returned bold ANSI output and broke its plain-string assertions.process.env.NO_COLOR = '1'in the plugin-dts Rstest config was added to work around that.Since
@rstest/core0.12.2 (web-infra-dev/rstest#1893), Rstest no longer writes any color env into workers.Changes
NO_COLORoverride frompackages/plugin-dts/rstest.config.ts.@rstest/coreand@rstest/adapter-rslibcatalog ranges to^0.12.2and refresh the lockfile accordingly.With
CI=true, the unit suite passes without the override. On@rstest/core0.12.1, theprettyTimetest fails without it.