Repository navigation
[wasm] Source Phase Imports for ESM Integration - #42467
Merged
Ms2ger merged 11 commits intoNov 17, 2023
Merged
Conversation
lucacasonato
left a comment
Member
There was a problem hiding this comment.
This can be rewritten as a .any.js file which will make this also runnable from Web Workers and Service Workers.
Contributor
|
Can it? Note |
Contributor
Author
|
I've split out the tests to separate the module source constructor tests from the HTML ones, so they should work across different contexts. I've also extended the ESM integration HTML worker test to include source phase imports. PTAL |
guybedford
force-pushed
the
source-phase-imports
branch
2 times, most recently
from
November 9, 2023 17:47
8e1e061 to
9c2a61f
Compare
Co-authored-by: Nicolò Ribaudo <hello@nicr.dev>
guybedford
force-pushed
the
source-phase-imports
branch
from
November 16, 2023 05:31
ed9b9d0 to
4565832
Compare
nicolo-ribaudo
approved these changes
Nov 17, 2023
Ms2ger
approved these changes
Nov 17, 2023
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test for the new source phase imports aspect of the ESM integration.
Includes tests both for using the source phase, and for checking that the prototype behaviours match the updated requirements on
WebAssembly.ModuleextendingAbstractModuleSource.Per the note in https://github.com/WebAssembly/esm-integration#es-module-integration-proposal-for-webassembly, it is possible for implementations to implement source phase imports independently from non-source-phase imports. I don't know if there's a way we want to reflect that in the test structure though?