chore(perf): improve caching in SplitChunksPlugin - #21529
Conversation
avivkeller
commented
Jul 27, 2026
🦋 Changeset detectedLatest commit: 5ad2572 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PR SummaryMedium Risk Overview When finding subset chunk sets in Caching changes: unnamed Adds a Reviewed by Cursor Bugbot for commit 5ad2572. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
This PR is packaged and the instant preview is available (bcb1abd). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@bcb1abd
yarn add -D webpack@https://pkg.pr.new/webpack@bcb1abd
pnpm add -D webpack@https://pkg.pr.new/webpack@bcb1abd |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21529 +/- ##
==========================================
+ Coverage 93.59% 93.79% +0.20%
==========================================
Files 619 620 +1
Lines 73650 73315 -335
Branches 21244 21192 -52
==========================================
- Hits 68933 68769 -164
+ Misses 4717 4546 -171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 22.94%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' |
1.3 MB | 3.1 MB | -58.15% |
| ⚡ | Memory | benchmark "asset-modules-resource", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' |
1,202.1 KB | 847.2 KB | +41.88% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing splitchunkspluginperf (5ad2572) with main (59566fc)
|
@codspeedbot is this regression relevant to the changes, I don't think so |
You're right — this regression does not look attributable to the SplitChunksPlugin changes. Here's what I found: The flagged benchmark doesn't exercise the changed code. The regressed benchmark is The paired result points to measurement noise, not the change. The only other moved benchmark is the improvement, Scope check. I reviewed So the 22.94% headline is being driven by this single unrelated Memory-rebuild benchmark. I'd treat it as noise and acknowledge it rather than chase it as a real regression from this PR. The benchmarks that would reflect your change (e.g. One caveat worth flagging: CodSpeed also reports that several benchmarks ran across different runtime environments (Intel vs AMD CPUs) between base and head. The Summary
Was this response helpful? React with 👍 or 👎 to help us improve CodSpeedBot. |