Repository navigation
ci: rename the parser job to spec and run CSS, HTML and XML in one leg - #22870
Conversation
|
Types CoverageCoverage after merging ci/merge-spec-legs into main will be
Coverage Report |
|
This PR is packaged and the instant preview of its latest commit is available. Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@22870
yarn add -D webpack@https://pkg.pr.new/webpack@22870
pnpm add -D webpack@https://pkg.pr.new/webpack@22870 |
Generated code sizeComparing base (
Read No asset changed size. No runtime gained or lost a runtime module. Built |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Change: Other Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check |  |
The title uses valid Conventional Commit syntax with the allowed type "ci" and accurately describes the CI job rename and suite merge. The branch prefix is not provided, so the required type-to-branch… | Provide the branch name or confirm that its prefix is "ci". |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Title check
-
Explanation
The title uses valid Conventional Commit syntax with the allowed type "ci" and accurately describes the CI job rename and suite merge. The branch prefix is not provided, so the required type-to-branch-prefix match cannot be verified.
Resolution
Provide the branch name or confirm that its prefix is "ci".
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Merging this PR will improve performance by 21.25%2 warnings, 1 note
Performance Changes
Tip Curious why performance improved? Comment Comparing 
|
Summary
The
css,htmlandxmllegs each run in 1–2 min, less than a runner's own setup. They now share one leg,spec (css-html-xml), which runs the three suites in a single Jest call. The job is renamed fromparsertospec, since it also runs the minifier suites. None of its checks are required for merge.parser (css),(html),(js),(minify-corpora),(minify-fuzz),(xml)spec (css-html-xml),(js),(minify-corpora),(minify-fuzz)The same suites still run on every PR. Coverage for the merged leg goes up under one
css-html-xmlflag, which replacescss-parsing,html5libandxmlconfincodecov.yml. The per-suitetest:/cover:scripts stay for local runs.What kind of change does this PR introduce?
ci
Did you add tests for your changes?
No, CI configuration only.
yarn cover:spec-css-html-xml --listTestslists exactly the three suites.Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Updated the job names in
TESTING_DOCS.mdanddocs/architecture.md.Use of AI
Claude Code wrote the change on my request; I reviewed the plan before it was made.
Generated by Claude Code
Summary by CodeRabbit