Skip to content

Where is non-GET/POST stored #1524

Closed

Description

@annevk

Another question for @smaug---- and @majido. The HTML Standard hints at some point that history session entries store whether the URL was retrieved using GET or POST.

This information is also used when a document is reloaded (a prompt shows up to ask the user if they're sure they want to submit the data again). Would we then get it from the session history's current entry or is it also stored elsewhere?

Activity

  1. smaug---- commented on Jul 8, 2016

    @smaug----

    "also stored"? Is there a thing stored elsewhere?

    Anyhow, Gecko stores the post data in session history entry
    http://searchfox.org/mozilla-central/rev/f43c9e0ffa92e72dbdbcbf57eecf04a43d46da63/docshell/shistory/nsSHEntry.h#56
    and that is used when reloading
    http://searchfox.org/mozilla-central/rev/f43c9e0ffa92e72dbdbcbf57eecf04a43d46da63/docshell/base/nsDocShell.cpp#12361
    Necko then uses "POST" method if such post data is used.

  2. annevk commented on Jul 8, 2016

    @annevk
    MemberAuthor

    "also stored"? Is there a thing stored elsewhere?

    I was just curious if I missed something. I suspect this can probably all live on the session history entry as "form data" (as it's called now). That's probably good enough although maybe not as there's also the correct Content-Type header to set, Referer might have to be reused, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions