Skip to content

Rename PopoverTargetElement mixin to PopoverInvokerElement #8979

Closed
Closed
Rename PopoverTargetElement mixin to PopoverInvokerElement#8979
Labels
clarificationStandard could be clearertopic: popoverThe popover attribute and friends

Description

@nt1m
nt1m
opened on Mar 3, 2023

This is mostly a nit, but I think it makes more sense, since the mixins apply to the invokers, not the popover targets.

@mfreed7 @josepharhar @annevk wdyt?

Activity

  1. annevk
    added
    clarificationStandard could be clearer
    topic: popoverThe popover attribute and friends
    on Mar 3, 2023

  2. josepharhar commented on Mar 3, 2023

    @josepharhar
    josepharhar
    on Mar 3, 2023
    Contributor

    I agree! Let's change it

  3. josepharhar commented on Mar 3, 2023

    @josepharhar
    josepharhar
    on Mar 3, 2023
    Contributor

    Here is a patch to implement it in chrome: https://chromium-review.googlesource.com/c/chromium/src/+/4307849

  4. annevk
    closed this as completedin dc27ce8on Mar 8, 2023
  5. aarongable
    added a commit that references this issue on Mar 8, 2023

    Rename IDL mixin type name to PopoverInvokerElement

    6b96ae3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    clarificationStandard could be clearertopic: popoverThe popover attribute and friends

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions