Repository navigation
Conversation
4f63023 to
5d63e86
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
https://html.spec.whatwg.org/#the-meta-element
But just below:
So |
This comment was marked as resolved.
This comment was marked as resolved.
|
@annevk can you help whether the @mtrootyy wrote:
|
5d63e86 to
ad98ae3
Compare
ad98ae3 to
49c5445
Compare
fe4fc74 to
615fb1c
Compare
There was a problem hiding this comment.
(Unofficial as I'm not an approver and we need multi implementer support)
I think this PR does the right thing in a way that's concise and consistent enough.
Editorially I can't say about maintaining the outdated wording style of existing meta tag or moving forward.
| <div algorithm> | ||
| <p>If a <code>meta</code> element is | ||
| <span data-x="node is inserted into a document">inserted into the document</span>, | ||
| the user agent must run the following algorithm:</p> |
There was a problem hiding this comment.
I think this wording style is outdated but will leave to @annevk whether this needs to be consistent with what's around it or with new style.
There was a problem hiding this comment.
OK I looked at other meta elements and you need to check for the name here. Are you ignoring the content? If so it's good to add a note.
Does changing the name attribute work? Is the matching case-sensitive?
Follow based on how other meta elements are speced.
There was a problem hiding this comment.
Thanks again, I read others and followed them. Can you check?
|
@kojiishi the tests link points to existing tests in wpt.fyi that are not marked tentative. |
I removed
Yes, I think so, though they're based on the previous understanding of the "immutable" in the CSS WG. Among the wpt tests:
I'll update/add tests and Blink once this discussion is settled down. |
| <div algorithm> | ||
| <p>If a <code>meta</code> element is | ||
| <span data-x="node is inserted into a document">inserted into the document</span>, | ||
| the user agent must run the following algorithm:</p> |
There was a problem hiding this comment.
OK I looked at other meta elements and you need to check for the name here. Are you ignoring the content? If so it's good to add a note.
Does changing the name attribute work? Is the matching case-sensitive?
Follow based on how other meta elements are speced.
615fb1c to
6404dc1
Compare
|
WHATNOT notes/minutes: Responsive Iframe Meta Tag Proposal: Noam Rosenthal introduced a proposal (PR 12444) to add a meta tag for responsive embedded sizing, which serves as an opt-in for parents to resize iframes. Luke questioned if domain-specific opt-ins are necessary, but Simon Pieters noted that CSP frame ancestors already provide existing protections. The group discussed whether the meta tag provides sufficient control over cross-origin information access, with Noam Rosenthal comparing the functionality to an explicit post-message opt-in. Responsive Iframe Data Leakage Concerns: The group discussed potential privacy risks, specifically whether responsive iframes could allow an origin to infer information about a user (e.g., whether they are logged into a site) based on size changes. Emilio Cobos Álvarez noted that the CSS working group previously discussed these risks and deemed them manageable if the parent page manages the sizing. Simon Pieters raised concerns regarding how to handle navigations and potential data leakage between pages. Responsive Iframe Implementation and Documentation: Luke suggested that browsers should provide console warnings if an iframe opts into this feature without appropriate frame ancestor restrictions. Noam Rosenthal committed to updating the security explainer for the PR and consulting with Koji to ensure privacy concerns are addressed. Philip Jägenstedt clarified that fence frames, while still present in Chromium code, are not currently being actively developed. |
|
I got another feedback from our security folks to add |
6404dc1 to
43cbcf8
Compare
43cbcf8 to
89778a0
Compare
This patch support the `allowed-origins` attribute of the `<meta>` element for responsively-sized iframes. The addition of this attribute is discussed with the security team, and is currently being discussed at WHATWG[1]. This attribute has the same syntax as CSP `frame-ancestors`, and that it reuses the underlying logic. It restricts the effect of `responsive-embedded-sizing` meta tag by the origin of the container. All the changes are under an experimental runtime flag. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I2af4c4d4e80e1a3efb8b52ad512f1493157d01b8
This patch support the `allowed-origins` attribute of the `<meta>` element for responsively-sized iframes. The addition of this attribute is discussed with the security team, and is currently being discussed at WHATWG[1]. This attribute has the same syntax as CSP `frame-ancestors`, and that it reuses the underlying logic. It restricts the effect of `responsive-embedded-sizing` meta tag by the origin of the container. All the changes are under an experimental runtime flag. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I2af4c4d4e80e1a3efb8b52ad512f1493157d01b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8084061 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1663715}
This patch renames the attribute as per the WHATWG feedback[1]. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I185e7e7de5411bbfe5d1a6a1c972e05dba49101d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8173946 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1673080} Co-authored-by: Koji Ishii <kojii@chromium.org>
…bute, a=testonly Automatic update from web-platform-tests [iframe] Support `allowed-origins` attribute (#61344) This patch support the `allowed-origins` attribute of the `<meta>` element for responsively-sized iframes. The addition of this attribute is discussed with the security team, and is currently being discussed at WHATWG[1]. This attribute has the same syntax as CSP `frame-ancestors`, and that it reuses the underlying logic. It restricts the effect of `responsive-embedded-sizing` meta tag by the origin of the container. All the changes are under an experimental runtime flag. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I2af4c4d4e80e1a3efb8b52ad512f1493157d01b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8084061 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1663715} Co-authored-by: Koji Ishii <kojii@chromium.org> -- wpt-commits: f1401e8ac6cac0cbe6f3008fbbc0edafd73b9d34 wpt-pr: 61344
For specifying the allowed origins, instead of adding a new attribute, as per the feedback[1]. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I78705424dd480737e1204f54e880a86071525c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8211759 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1674776} Co-authored-by: Koji Ishii <kojii@chromium.org>
…loworigins`, a=testonly Automatic update from web-platform-tests [iframe] Rename `allowed-origins` to `alloworigins` (#61725) This patch renames the attribute as per the WHATWG feedback[1]. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I185e7e7de5411bbfe5d1a6a1c972e05dba49101d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8173946 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1673080} Co-authored-by: Koji Ishii <kojii@chromium.org> -- wpt-commits: 5e75769b378a7ebf3831c0f3e73042518c7f8209 wpt-pr: 61725
e805016 to
093def9
Compare
…testonly Automatic update from web-platform-tests [iframe] Use the `content` attribute (#61797) For specifying the allowed origins, instead of adding a new attribute, as per the feedback[1]. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I78705424dd480737e1204f54e880a86071525c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8211759 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1674776} Co-authored-by: Koji Ishii <kojii@chromium.org> -- wpt-commits: b47d3bcbff5bbe2ed05253056c244d3dab686c36 wpt-pr: 61797
Discussing this point with our security folks turned out that they think Are you good with |
|
@kojiishi OK. |
093def9 to
1d50e5d
Compare
This patch changes the `content` attribute of the `<meta>` element whose name is `responsive-embedded-sizing` to require the `allow-origins=` prefix, as discussed at [1]. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I56c233c72ed8cdefad347cddc842d0e8904f3598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8293941 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1686940}
This patch changes the `content` attribute of the `<meta>` element whose name is `responsive-embedded-sizing` to require the `allow-origins=` prefix, as discussed at [1]. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I56c233c72ed8cdefad347cddc842d0e8904f3598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8293941 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1686940} Co-authored-by: Koji Ishii <kojii@chromium.org>
1d50e5d to
e8e002b
Compare
…, a=testonly Automatic update from web-platform-tests [iframe] Require `allow-origins=` prefix (#62229) This patch changes the `content` attribute of the `<meta>` element whose name is `responsive-embedded-sizing` to require the `allow-origins=` prefix, as discussed at [1]. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I56c233c72ed8cdefad347cddc842d0e8904f3598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8293941 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1686940} Co-authored-by: Koji Ishii <kojii@chromium.org> -- wpt-commits: 2beef90fd2b8d267ebed384b0edc7f59f309f991 wpt-pr: 62229
|
The CSS Working Group just discussed The full IRC log of that discussion<keithamus> astearns: a PR from Koji<keithamus> astearns: I did not look through to see who added it to our agenda <keithamus> masonf: Noam <keithamus> astearns: who is not here. Anything we can do, or shall we push until Noam is on the call? <keithamus> masonf: PR with comments from a few days ago. I say we keep it on agenda for next week <keithamus> astearns: skipped. |
This adds `<meta name="responsive-embedded-sizing">` as an immutable standardized name. This is used by the CSS [responsive embedded sizing flag]. [responsive embedded sizing flag]: https://drafts.csswg.org/css-sizing-4/#document-responsive-embedded-sizing-flag
e8e002b to
8fd9d89
Compare
For specifying the allowed origins, instead of adding a new attribute, as per the feedback[1]. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I78705424dd480737e1204f54e880a86071525c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8211759 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1674776}
This patch changes the `content` attribute of the `<meta>` element whose name is `responsive-embedded-sizing` to require the `allow-origins=` prefix, as discussed at [1]. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I56c233c72ed8cdefad347cddc842d0e8904f3598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8293941 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1686940}
AI ReviewReviewed at Cross-spec consistency with css-sizing-4The CSS side (§ HTML iframe details) currently disagrees with this PR in four ways, and I think at least (3) is new since the last round:
Suggest linking the csswg-drafts PR from the OP so they land together. What "reveal" implies for the opt-in window
None of this is necessarily wrong — it is consistent with how render-blocking is bounded — but the PR description/commit message should state the model ("fixed at first rendering update") since it's the thing implementers will test against. @zcorpan's thread about resetting the locked embedded ICB size on navigation still looks open; that's a CSS-side formalization but is the other half of the leak argument.
|
…bute, a=testonly Automatic update from web-platform-tests [iframe] Support `allowed-origins` attribute (#61344) This patch support the `allowed-origins` attribute of the `<meta>` element for responsively-sized iframes. The addition of this attribute is discussed with the security team, and is currently being discussed at WHATWG[1]. This attribute has the same syntax as CSP `frame-ancestors`, and that it reuses the underlying logic. It restricts the effect of `responsive-embedded-sizing` meta tag by the origin of the container. All the changes are under an experimental runtime flag. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I2af4c4d4e80e1a3efb8b52ad512f1493157d01b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8084061 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1663715} Co-authored-by: Koji Ishii <kojii@chromium.org> -- wpt-commits: f1401e8ac6cac0cbe6f3008fbbc0edafd73b9d34 wpt-pr: 61344
…loworigins`, a=testonly Automatic update from web-platform-tests [iframe] Rename `allowed-origins` to `alloworigins` (#61725) This patch renames the attribute as per the WHATWG feedback[1]. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I185e7e7de5411bbfe5d1a6a1c972e05dba49101d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8173946 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1673080} Co-authored-by: Koji Ishii <kojii@chromium.org> -- wpt-commits: 5e75769b378a7ebf3831c0f3e73042518c7f8209 wpt-pr: 61725
…testonly Automatic update from web-platform-tests [iframe] Use the `content` attribute (#61797) For specifying the allowed origins, instead of adding a new attribute, as per the feedback[1]. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I78705424dd480737e1204f54e880a86071525c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8211759 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1674776} Co-authored-by: Koji Ishii <kojii@chromium.org> -- wpt-commits: b47d3bcbff5bbe2ed05253056c244d3dab686c36 wpt-pr: 61797
…, a=testonly Automatic update from web-platform-tests [iframe] Require `allow-origins=` prefix (#62229) This patch changes the `content` attribute of the `<meta>` element whose name is `responsive-embedded-sizing` to require the `allow-origins=` prefix, as discussed at [1]. [1]: whatwg/html#12444 (comment) Bug: 418397278 Change-Id: I56c233c72ed8cdefad347cddc842d0e8904f3598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8293941 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1686940} Co-authored-by: Koji Ishii <kojii@chromium.org> -- wpt-commits: 2beef90fd2b8d267ebed384b0edc7f59f309f991 wpt-pr: 62229
This adds
<meta name="responsive-embedded-sizing">as an immutable standardized name.This is used by the CSS responsive embedded sizing flag.
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/dom.html ( diff )
/infrastructure.html ( diff )
/semantics.html ( diff )