Repository navigation
Focus the viewport when closing a dialog without previous focus - #13119
Open
hjanuschka wants to merge 1 commit into
Open
hjanuschka wants to merge 1 commit into
hjanuschka wants to merge 1 commit into
Conversation
When no element was focused before the dialog opened, closing it can leave focus inside the closed dialog until asynchronous focus fixup. Focus the viewport synchronously when focus is still inside the dialog. Tests: https://chromium-review.googlesource.com/c/chromium/src/+/8644932 Fixes whatwg#13118.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a dialog closes without a previously focused element, its current focus can remain inside the closed dialog until the asynchronous focus fixup runs. Focus the document's viewport synchronously if focus is still inside the dialog; leave focus elsewhere alone.
Fixes #13118.
/acknowledgements.html ( diff )
/interactive-elements.html ( diff )