Rename the spec and API by domenic · Pull Request #203 · WICG/navigation-api

domenic · 2022-03-08T19:27:35Z

Closes #83.

See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL implements the following renames: * window.appHistory → window.navigation * appHistory.current → navigation.currentEntry * appHistory.updateCurrent() → navigation.updateCurrentEntry() * appHistory currentchange event → navigation currententrychange event * appHistory.goTo() → navigation.traverseTo() Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing. No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either. Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class. Bug: 1300246 Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557

See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL implements the following renames: * window.appHistory → window.navigation * appHistory.current → navigation.currentEntry * appHistory.updateCurrent() → navigation.updateCurrentEntry() * appHistory currentchange event → navigation currententrychange event * appHistory.goTo() → navigation.traverseTo() Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing. No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either. Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class. Bug: 1300246 Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510372 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#980648}

See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL implements the following renames: * window.appHistory → window.navigation * appHistory.current → navigation.currentEntry * appHistory.updateCurrent() → navigation.updateCurrentEntry() * appHistory currentchange event → navigation currententrychange event * appHistory.goTo() → navigation.traverseTo() Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing. No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either. Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class. Bug: 1300246 Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510372 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#980648}

See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames all test files, with occasional minor updates to their contents. Notably this includes web platform test files. While doing so, some of the web platform tests were slightly moved around to give a clearer directory structure. This revealed some confusing duplication (and in some cases mislocated tests) around state updates, which is tracked in https://crbug.com/1304446. Bug: 1300246 Change-Id: Ieef0329e7a309c242b5391f050878bc182487905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510194 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#980702}

See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL implements the following renames: * window.appHistory → window.navigation * appHistory.current → navigation.currentEntry * appHistory.updateCurrent() → navigation.updateCurrentEntry() * appHistory currentchange event → navigation currententrychange event * appHistory.goTo() → navigation.traverseTo() Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing. No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either. Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class. Bug: 1300246 Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510372 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#980648} Co-authored-by: Domenic Denicola <domenic@chromium.org>

See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames all test files, with occasional minor updates to their contents. Notably this includes web platform test files. While doing so, some of the web platform tests were slightly moved around to give a clearer directory structure. This revealed some confusing duplication (and in some cases mislocated tests) around state updates, which is tracked in https://crbug.com/1304446. Bug: 1300246 Change-Id: Ieef0329e7a309c242b5391f050878bc182487905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510194 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#980702}

See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications. Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL. This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments. Bug: 1300246 Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c

See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications. Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL. This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments. Bug: 1300246 Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#981804}

See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications. Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL. This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments. Bug: 1300246 Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#981804}

See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames various "AppHistoryEntry" data structures and fields to "NavigationApiHistoryEntry". This crosses the Blink/browser boundary. Bug: 1300246 Change-Id: I878affd6c1ca2660b5d574bab8582467c9b51293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523006 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#981872}

See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames various fields of history entries, from "app history key", "app history id", "app history state", and "protect URL in app history" to their corresponding "navigation API" counterparts. This crosses the Blink/browser boundary. Bug: 1300246 Change-Id: Ifaf47859b49e971657c0e3c2217f1446b6a2bec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523469 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#981910}

See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL tidies up remaining references to app history across the codebase, mostly in comments and in enum names. Some DOMException messages also were forgotten in previous passes, and needed to be updated. Bug: 1300246 Change-Id: I10eeffb0cb6cc753679d45e450c8f5268bd500c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523471 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#982361}

See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames the Blink RuntimeEnabledFeature from AppHistory to NavigationApi. While here, we remove the origin_trial_feature_name key since the origin trial is no longer relevant to tip-of-trunk code. Bug: 1300246 Change-Id: I66dd86dce6d8bef7fa38353009fe6cea0cdbcf8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537549 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#982891}

… (1/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (1/n) (#33132) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL implements the following renames: * window.appHistory → window.navigation * appHistory.current → navigation.currentEntry * appHistory.updateCurrent() → navigation.updateCurrentEntry() * appHistory currentchange event → navigation currententrychange event * appHistory.goTo() → navigation.traverseTo() Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing. No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either. Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class. Bug: 1300246 Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510372 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#980648} Co-authored-by: Domenic Denicola <domenic@chromium.org> -- wpt-commits: 610b3657dbcfe8b740cfad0faaef7f1ad9897af8 wpt-pr: 33132

… (2/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (2/n) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames all test files, with occasional minor updates to their contents. Notably this includes web platform test files. While doing so, some of the web platform tests were slightly moved around to give a clearer directory structure. This revealed some confusing duplication (and in some cases mislocated tests) around state updates, which is tracked in https://crbug.com/1304446. Bug: 1300246 Change-Id: Ieef0329e7a309c242b5391f050878bc182487905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510194 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#980702} -- wpt-commits: 4e628b145e52797f421c7f832d13014387aac961 wpt-pr: 33182

… (3/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (3/n) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications. Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL. This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments. Bug: 1300246 Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#981804} -- wpt-commits: 3f00a909b6e15e281fe3dbbac376542465cc5232 wpt-pr: 33184