Skip to content

[view-transitions] Update callback can incorrectly be called multiple times - #33091

Merged
webkit-commit-queue merged 0 commit into
WebKit:mainfrom
nt1m:eng/view-transitions-Update-callback-can-be-called-twice
Sep 4, 2024
Merged

[view-transitions] Update callback can incorrectly be called multiple times#33091
webkit-commit-queue merged 0 commit into
WebKit:mainfrom
nt1m:eng/view-transitions-Update-callback-can-be-called-twice

Conversation

@nt1m

@nt1m nt1m commented Sep 3, 2024 •
edited by webkit-early-warning-system
Loading

Copy link
Copy Markdown
Member

dba893b

[view-transitions] Update callback can incorrectly be called multiple times
https://bugs.webkit.org/show_bug.cgi?id=279087
rdar://135226640

Reviewed by Matt Woodrow.

This is currently a spec bug, see:
- w3c/csswg-drafts#10826
- w3c/csswg-drafts#10822

* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/update-callback-called-once-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/update-callback-called-once.html: Added.
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::callUpdateCallback):

Canonical link: https://commits.webkit.org/283167@main

324b3a2

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ⏳ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m
nt1m requested review from cdumez and rniwa as code owners September 3, 2024 23:30
@nt1m nt1m self-assigned this Sep 3, 2024
@nt1m nt1m added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Sep 3, 2024
@webkit-early-warning-system

webkit-early-warning-system commented Sep 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on previous version of this PR (hash afbf385)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ⏳ 🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2   🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
✅ 🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2
  🛠 tv
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@nt1m
nt1m requested a review from mattwoodrow September 3, 2024 23:31
@nt1m nt1m mentioned this pull request Sep 3, 2024
Closed
@nt1m nt1m changed the title [view-transitions] Update callback can be called twice [view-transitions] Update callback can incorrectly be called multiple times Sep 3, 2024
@nt1m
nt1m force-pushed the eng/view-transitions-Update-callback-can-be-called-twice branch from afbf385 to 0d391e3 Compare September 3, 2024 23:35
@webkit-early-warning-system

webkit-early-warning-system commented Sep 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on previous version of this PR (hash 0d391e3)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ⏳ 🧪 api-gtk
✅ 🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2
  🛠 tv
  🛠 tv-sim
  🛠 watch
✅ 🛠 watch-sim

@nt1m
nt1m force-pushed the eng/view-transitions-Update-callback-can-be-called-twice branch from 0d391e3 to 5d9cd92 Compare September 4, 2024 01:02
@webkit-early-warning-system

webkit-early-warning-system commented Sep 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on previous version of this PR (hash 5d9cd92)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 4, 2024
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Sep 4, 2024
@nt1m
nt1m force-pushed the eng/view-transitions-Update-callback-can-be-called-twice branch from 5d9cd92 to 5a44244 Compare September 4, 2024 16:06
@webkit-early-warning-system

webkit-early-warning-system commented Sep 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on previous version of this PR (hash 5a44244)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-intel-wk2
✅ 🛠 tv
  🛠 tv-sim
  🛠 watch
✅ 🛠 watch-sim

@nt1m
nt1m force-pushed the eng/view-transitions-Update-callback-can-be-called-twice branch from 5a44244 to 324b3a2 Compare September 4, 2024 16:31
@webkit-early-warning-system

webkit-early-warning-system commented Sep 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on current version of this PR (hash 324b3a2)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ⏳ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Sep 4, 2024
@webkit-commit-queue

webkit-commit-queue commented Sep 4, 2024

Copy link
Copy Markdown
Collaborator

Committed 283167@main (dba893b): https://commits.webkit.org/283167@main

Reviewed commits have been landed. Closing PR #33091 and removing active labels.

@webkit-commit-queue
webkit-commit-queue force-pushed the eng/view-transitions-Update-callback-can-be-called-twice branch from 324b3a2 to dba893b Compare September 4, 2024 18:09
@webkit-commit-queue
webkit-commit-queue merged commit dba893b into WebKit:main Sep 4, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 4, 2024
@nt1m
nt1m deleted the eng/view-transitions-Update-callback-can-be-called-twice branch September 4, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattwoodrow mattwoodrow mattwoodrow approved these changes
@rniwa rniwa Awaiting requested review from rniwa
@cdumez cdumez Awaiting requested review from cdumez

Assignees

@nt1m nt1m

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nt1m @webkit-early-warning-system @webkit-commit-queue @mattwoodrow @webkit-ews-buildbot