Skip to content

Ignore outline-width when outline-style is auto - #61497

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
annevk:eng/Ignore-outline-width-when-outline-style-is-auto
Mar 28, 2026
Merged

webkit-commit-queue merged 1 commit into
WebKit:mainfrom
annevk:eng/Ignore-outline-width-when-outline-style-is-auto

Conversation

@annevk

@annevk annevk commented Mar 27, 2026 •

Copy link
Copy Markdown
Contributor

b474f3f

Ignore outline-width when outline-style is auto
https://bugs.webkit.org/show_bug.cgi?id=310898

Reviewed by Tim Nguyen.

Having refactored html.css in 309812@main to no longer set
outline-width, aligning with the standard here is much more realistic
and will give us a tiny web-platform-tests win.

svg/custom/focus-ring.svg had to be adjusted slightly now we ignore
outline-width for auto and to make sure the test continues working we
add support for outline-offset to SVG.

Adwaita uses a width of 2px which originally would often give it a 1px
gap as the outline-width was often 3px (default value). Now that is no
longer the case there is some slight bleeding of the outline into the
content for the various caret tests that zoom in a lot which is why
they appear regressed. It doesn't seem like it should be a problem in
practice, but there is a bug filed for them to look into outline again.

Canonical link: https://commits.webkit.org/310145@main

dc7d70e

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe loading 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
  🛠 watch-sim

@annevk annevk self-assigned this Mar 27, 2026
@annevk annevk added the CSS Cascading Style Sheets implementation label Mar 27, 2026
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 27, 2026
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label Mar 27, 2026
@annevk
annevk force-pushed the eng/Ignore-outline-width-when-outline-style-is-auto branch from 02bfa75 to 8d1d1f9 Compare March 27, 2026 21:16
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 27, 2026
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label Mar 28, 2026
@annevk
annevk force-pushed the eng/Ignore-outline-width-when-outline-style-is-auto branch from 8d1d1f9 to dc7d70e Compare March 28, 2026 05:27
@annevk annevk added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 28, 2026
https://bugs.webkit.org/show_bug.cgi?id=310898

Reviewed by Tim Nguyen.

Having refactored html.css in 309812@main to no longer set
outline-width, aligning with the standard here is much more realistic
and will give us a tiny web-platform-tests win.

svg/custom/focus-ring.svg had to be adjusted slightly now we ignore
outline-width for auto and to make sure the test continues working we
add support for outline-offset to SVG.

Adwaita uses a width of 2px which originally would often give it a 1px
gap as the outline-width was often 3px (default value). Now that is no
longer the case there is some slight bleeding of the outline into the
content for the various caret tests that zoom in a lot which is why
they appear regressed. It doesn't seem like it should be a problem in
practice, but there is a bug filed for them to look into outline again.

Canonical link: https://commits.webkit.org/310145@main
@webkit-commit-queue
webkit-commit-queue force-pushed the eng/Ignore-outline-width-when-outline-style-is-auto branch from dc7d70e to b474f3f Compare March 28, 2026 06:26
@webkit-commit-queue

Copy link
Copy Markdown
Collaborator

Committed 310145@main (b474f3f): https://commits.webkit.org/310145@main

Reviewed commits have been landed. Closing PR #61497 and removing active labels.

@webkit-commit-queue
webkit-commit-queue merged commit b474f3f into WebKit:main Mar 28, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 28, 2026
@annevk
annevk deleted the eng/Ignore-outline-width-when-outline-style-is-auto branch March 28, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CSS Cascading Style Sheets implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants