Repository navigation
Ignore outline-width when outline-style is auto - #61497
Merged
webkit-commit-queue merged 1 commit intoMar 28, 2026
Merged
webkit-commit-queue merged 1 commit into
webkit-commit-queue merged 1 commit into
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 02bfa75) Details |
nt1m
approved these changes
Mar 27, 2026
annevk
force-pushed
the
eng/Ignore-outline-width-when-outline-style-is-auto
branch
from
March 27, 2026 21:16
02bfa75 to
8d1d1f9
Compare
Collaborator
|
EWS run on previous version of this PR (hash 8d1d1f9) Details
|
annevk
force-pushed
the
eng/Ignore-outline-width-when-outline-style-is-auto
branch
from
March 28, 2026 05:27
8d1d1f9 to
dc7d70e
Compare
Collaborator
|
EWS run on current version of this PR (hash dc7d70e) Details
|
https://bugs.webkit.org/show_bug.cgi?id=310898 Reviewed by Tim Nguyen. Having refactored html.css in 309812@main to no longer set outline-width, aligning with the standard here is much more realistic and will give us a tiny web-platform-tests win. svg/custom/focus-ring.svg had to be adjusted slightly now we ignore outline-width for auto and to make sure the test continues working we add support for outline-offset to SVG. Adwaita uses a width of 2px which originally would often give it a 1px gap as the outline-width was often 3px (default value). Now that is no longer the case there is some slight bleeding of the outline into the content for the various caret tests that zoom in a lot which is why they appear regressed. It doesn't seem like it should be a problem in practice, but there is a bug filed for them to look into outline again. Canonical link: https://commits.webkit.org/310145@main
webkit-commit-queue
force-pushed
the
eng/Ignore-outline-width-when-outline-style-is-auto
branch
from
March 28, 2026 06:26
dc7d70e to
b474f3f
Compare
Collaborator
|
Committed 310145@main (b474f3f): https://commits.webkit.org/310145@main Reviewed commits have been landed. Closing PR #61497 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 bindings
b474f3f
dc7d70e
🛠 win🧪 win-tests🧪 ios-wk2🧪 ios-wk2-wpt🧪 api-mac-debug🧪 api-ios🧪 mac-AS-debug-wk2🛠 playstation🛠 watch-sim