AX: Translate accessibility announcements (ARIA Notify, live regions) when the page is presented as a machine translation by twilco · Pull Request #71083 · WebKit/WebKit

twilco · 2026-08-06T21:19:15Z

`2b96b32`

AX: Translate accessibility announcements (ARIA Notify, live regions) when the page is presented as a machine translation
https://bugs.webkit.org/show_bug.cgi?id=321206
rdar://184264303

Reviewed by Dominic Mazzoni.

Core-AAM adds a normative requirement that when a user agent presents a document as a machine
translation, it must translate ariaNotify() and live region announcements before handing it to
the platform, so that assistive technology conveys it in the language that is visually presented.

WebKit did not do this. Safari translates a page by rewriting the DOM through the text manipulation
SPI, which cannot reach either case. ariaNotify() strings come from script and never enter the DOM,
and a live region announcement is computed from the DOM and posted on a zero-delay timer, before the
translation round trip replaces the text. The result was announcements spoken in the original
language, and live regions spoken twice.

Announcements are now held in a FIFO queue in AXObjectCache while the embedder is asked to translate
them, through a new _WKTranslationDelegate. WebKit cannot translate text itself, instead relying on
TranslationUIServices, allowing the client to supply it. The client also tells WebKit it's presenting
a translation by setting -_displayedTranslationLocaleIdentifier. With no locale set, the behavior is
unchanged.

Ordering and failure handling are the substance of the change. Translation requests are issued immediately and
in parallel, but announcements are released strictly in the order they were produced, so a slow
translation cannot let a later announcement overtake an earlier one. Each entry has a 250ms deadline,
after which the original text is announced in its original language, preventing a stalled or unavailable
translation service from blocking announcements outright. A translation client that declines, replies late, or drops
the completion handler entirely degrades the same way.

Finally, TextManipulationController now records the container it rewrites, so the children-changed
that its own text swap produces does not announce a live region a second time.

* LayoutTests/accessibility/ios-simulator/aria-notify-translated-expected.txt: Added.
* LayoutTests/accessibility/ios-simulator/aria-notify-translated.html: Added.
* LayoutTests/accessibility/mac/aria-notify-translated-expected.txt: Added.
* LayoutTests/accessibility/mac/aria-notify-translated.html: Added.
* LayoutTests/accessibility/mac/aria-notify-translation-dropped-handler-expected.txt: Added.
* LayoutTests/accessibility/mac/aria-notify-translation-dropped-handler.html: Added.
* LayoutTests/accessibility/mac/aria-notify-translation-failure-expected.txt: Added.
* LayoutTests/accessibility/mac/aria-notify-translation-failure.html: Added.
* LayoutTests/accessibility/mac/aria-notify-translation-late-reply-expected.txt: Added.
* LayoutTests/accessibility/mac/aria-notify-translation-late-reply.html: Added.
* LayoutTests/accessibility/mac/aria-notify-translation-not-active-expected.txt: Added.
* LayoutTests/accessibility/mac/aria-notify-translation-not-active.html: Added.
* LayoutTests/accessibility/mac/aria-notify-translation-ordering-expected.txt: Added.
* LayoutTests/accessibility/mac/aria-notify-translation-ordering.html: Added.
* LayoutTests/accessibility/mac/aria-notify-translation-timeout-expected.txt: Added.
* LayoutTests/accessibility/mac/aria-notify-translation-timeout.html: Added.
* LayoutTests/accessibility/mac/live-regions/live-region-translated-expected.txt: Added.
* LayoutTests/accessibility/mac/live-regions/live-region-translated.html: Added.
* Source/WebCore/accessibility/AXLiveRegionManager.cpp:
(WebCore::AXLiveRegionManager::postAnnouncementForChange):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::handleAllDeferredChildrenChanged):
(WebCore::AXObjectCache::handleChildrenChanged):
(WebCore::announcementTranslationTimeoutOverrideForTesting):
(WebCore::AXObjectCache::setAnnouncementTranslationTimeoutForTesting):
(WebCore::AXObjectCache::announcementTranslationTimeout):
(WebCore::AXObjectCache::translateAnnouncementThenAssemble):
(WebCore::AXObjectCache::deferReRenderedContent):
(WebCore::AXObjectCache::isReRenderedContent const):
(WebCore::AXObjectCache::announcementTranslationDidComplete):
(WebCore::AXObjectCache::flushPendingAnnouncements):
(WebCore::AXObjectCache::scheduleAnnouncementTimeoutTimerIfNeeded):
(WebCore::AXObjectCache::pendingAnnouncementTimeoutTimerFired):
(WebCore::AXObjectCache::postARIANotifyNotification):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::replace):
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::translateAccessibilityAnnouncementStrings):
* Source/WebCore/page/Page.cpp:
(WebCore::m_mediaSessionManagerFactory):
(WebCore::Page::setDisplayedTranslationLocaleIdentifier):
* Source/WebCore/page/Page.h:
(WebCore::Page::isPresentingMachineTranslation const):
* Source/WebCore/page/PageConfiguration.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setAccessibilityAnnouncementTranslationTimeout):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/Headers.cmake:
* Source/WebKit/PlatformCocoa.cmake:
* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/Shared/WebPageCreationParameters.serialization.in:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _translateAccessibilityAnnouncementStrings:sourceLocaleIdentifiers:targetLocaleIdentifier:completionHandler:]):
(-[WKWebView _translationDelegate]):
(-[WKWebView _setTranslationDelegate:]):
(-[WKWebView _displayedTranslationLocaleIdentifier]):
(-[WKWebView _setDisplayedTranslationLocaleIdentifier:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKTranslationDelegate.h: Added.
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::translateAccessibilityAnnouncementStrings):
* Source/WebKit/UIProcess/PageClient.h:
(WebKit::PageClient::translateAccessibilityAnnouncementStrings):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::displayedTranslationLocaleIdentifier const):
(WebKit::WebPageProxy::setDisplayedTranslationLocaleIdentifier):
(WebKit::WebPageProxy::translateAccessibilityAnnouncementStrings):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/WebPageProxyInternals.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::translateAccessibilityAnnouncementStrings):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_allowsImmersiveEnvironments):
(WebKit::WebPage::setDisplayedTranslationLocaleIdentifier):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/AccessibilityAnnouncementTranslation.mm: Added.
(TestWebKitAPI::TEST(AccessibilityAnnouncementTranslation, DisplayedTranslationLocaleRoundTripsAndResetsOnNavigation)):
* Tools/WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):
(WTR::TestOptions::keyTypeMapping):
* Tools/WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::announcementTranslationMode const):
(WTR::TestOptions::displayedTranslationLocale const):
* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::finishCreatingPlatformWebView):
* Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
* Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView initWithFrame:configuration:]):
(-[TestRunnerWKWebView _webView:translateAccessibilityAnnouncementStrings:sourceLocaleIdentifiers:targetLocaleIdentifier:completionHandler:]):

Canonical link: https://commits.webkit.org/318920@main

4218643

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	❌ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	🛠 gtk3-gcc
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-wk2-stress	✅ 🧪 gtk-wk2
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-intel-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🛠 mac-safer-cpp	✅ 🛠 playstation
	✅ 🛠 tv	🧪 mac-site-isolation
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-08-06T21:19:22Z

EWS run on previous version of this PR (hash b6ba13e)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	~~🛠 win~~	⏳ 🛠 ios-apple
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	~~🧪 win-tests~~	⏳ 🛠 mac-apple
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe		⏳ 🛠 vision-apple
	❌ 🧪 ios-wk2-wpt	❌ 🧪 api-mac-debug	❌ 🧪 jsc-wpe
❌ 🧪 jsc-x86-64	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🛠 gtk3-gcc
🛠 🧪 jsc-debug-arm64	❌ 🛠 ios-safer-cpp	❌ 🧪 mac-AS-debug-wk2	❌ 🛠 gtk
	❌ 🛠 vision	❌ 🧪 mac-wk2-stress	❌ 🧪 gtk-wk2
	❌ 🛠 vision-sim	❌ 🧪 mac-intel-wk2	❌ 🧪 api-gtk
	❌ 🧪 vision-wk2	❌ 🛠 mac-safer-cpp	❌ 🛠 playstation
	❌ 🛠 tv	❌ 🧪 mac-site-isolation
	❌ 🛠 tv-sim
	🛠 watch
	❌ 🛠 watch-sim

minorninth · 2026-08-06T22:01:56Z

+    return announcementTranslationTimeoutOverrideForTesting().value_or(defaultAnnouncementTranslationTimeout);
+}
+
+void AXObjectCache::translateAnnouncementThenAssemble(Ref<AccessibilityObject>&& object, Vector<String>&& segments, Vector<String>&& sourceLanguages, Function<void(Vector<String>&&, const String&)>&& assemble)


It'd probably be nice to use a vector of structs rather than parallel segments and sourceLanguages vectors.

Also, should we be using locale or language? Let's be consistent.

sourceLanguages ended up being unnecessary, so I removed it entirely.

Complete consistency might be difficult without touching unrelated code, since the translation infrastructure / Safari calls it "locale" while the AX APIs use "language".

minorninth · 2026-08-06T22:04:22Z

+    if (page) {
+        // Every announcement in a translated rendering needs translating.
+        targetLocale = page->displayedTranslationLocaleIdentifier();
+        needsTranslation = !targetLocale.isEmpty();


Should we be checking that individual strings aren't already in the target locale?

What happens if I enable machine translation to English but the page has a mix of English and another language?

Should we be checking that individual strings aren't already in the target locale?

I originally did this, but it ended up meaning the feature did nothing, since when the pages gets translated, the lang attribute of the html element gets set to the target language, meaning every element is technically already in the target locale via inheritance.

What happens if I enable machine translation to English but the page has a mix of English and another language?

It all gets translated to English — whatever is English stays as-is.

webkit-ews-buildbot · 2026-08-06T23:21:30Z

macOS Safer C++ Build #125800 (`b6ba13e`)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

webkit-ews-buildbot · 2026-08-06T23:27:02Z

iOS Safer C++ Build #45784 (`b6ba13e`)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

webkit-early-warning-system · 2026-08-07T00:28:35Z

EWS run on previous version of this PR (hash 72b2351)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	~~🛠 mac~~	❌ 🛠 wpe	~~🛠 win~~	⏳ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	~~🧪 win-tests~~	⏳ 🛠 mac-apple
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	❌ 🧪 api-wpe		⏳ 🛠 vision-apple
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~	❌ 🧪 jsc-wpe
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk3-gcc~~
	✅ 🛠 ios-safer-cpp	~~🧪 mac-AS-debug-wk2~~	❌ 🛠 gtk
	~~🛠 vision~~	~~🧪 mac-wk2-stress~~	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	~~🧪 mac-intel-wk2~~	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🛠 mac-safer-cpp	~~🛠 playstation~~
	✅ 🛠 tv	~~🧪 mac-site-isolation~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-08-07T01:52:30Z

EWS run on current version of this PR (hash 4218643)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	❌ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	🛠 gtk3-gcc
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-wk2-stress	✅ 🧪 gtk-wk2
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-intel-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🛠 mac-safer-cpp	✅ 🛠 playstation
	✅ 🛠 tv	🧪 mac-site-isolation
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

… when the page is presented as a machine translation https://bugs.webkit.org/show_bug.cgi?id=321206 rdar://184264303 Reviewed by Dominic Mazzoni. Core-AAM adds a normative requirement that when a user agent presents a document as a machine translation, it must translate ariaNotify() and live region announcements before handing it to the platform, so that assistive technology conveys it in the language that is visually presented. WebKit did not do this. Safari translates a page by rewriting the DOM through the text manipulation SPI, which cannot reach either case. ariaNotify() strings come from script and never enter the DOM, and a live region announcement is computed from the DOM and posted on a zero-delay timer, before the translation round trip replaces the text. The result was announcements spoken in the original language, and live regions spoken twice. Announcements are now held in a FIFO queue in AXObjectCache while the embedder is asked to translate them, through a new _WKTranslationDelegate. WebKit cannot translate text itself, instead relying on TranslationUIServices, allowing the client to supply it. The client also tells WebKit it's presenting a translation by setting -_displayedTranslationLocaleIdentifier. With no locale set, the behavior is unchanged. Ordering and failure handling are the substance of the change. Translation requests are issued immediately and in parallel, but announcements are released strictly in the order they were produced, so a slow translation cannot let a later announcement overtake an earlier one. Each entry has a 250ms deadline, after which the original text is announced in its original language, preventing a stalled or unavailable translation service from blocking announcements outright. A translation client that declines, replies late, or drops the completion handler entirely degrades the same way. Finally, TextManipulationController now records the container it rewrites, so the children-changed that its own text swap produces does not announce a live region a second time. * LayoutTests/accessibility/ios-simulator/aria-notify-translated-expected.txt: Added. * LayoutTests/accessibility/ios-simulator/aria-notify-translated.html: Added. * LayoutTests/accessibility/mac/aria-notify-translated-expected.txt: Added. * LayoutTests/accessibility/mac/aria-notify-translated.html: Added. * LayoutTests/accessibility/mac/aria-notify-translation-dropped-handler-expected.txt: Added. * LayoutTests/accessibility/mac/aria-notify-translation-dropped-handler.html: Added. * LayoutTests/accessibility/mac/aria-notify-translation-failure-expected.txt: Added. * LayoutTests/accessibility/mac/aria-notify-translation-failure.html: Added. * LayoutTests/accessibility/mac/aria-notify-translation-late-reply-expected.txt: Added. * LayoutTests/accessibility/mac/aria-notify-translation-late-reply.html: Added. * LayoutTests/accessibility/mac/aria-notify-translation-not-active-expected.txt: Added. * LayoutTests/accessibility/mac/aria-notify-translation-not-active.html: Added. * LayoutTests/accessibility/mac/aria-notify-translation-ordering-expected.txt: Added. * LayoutTests/accessibility/mac/aria-notify-translation-ordering.html: Added. * LayoutTests/accessibility/mac/aria-notify-translation-timeout-expected.txt: Added. * LayoutTests/accessibility/mac/aria-notify-translation-timeout.html: Added. * LayoutTests/accessibility/mac/live-regions/live-region-translated-expected.txt: Added. * LayoutTests/accessibility/mac/live-regions/live-region-translated.html: Added. * Source/WebCore/accessibility/AXLiveRegionManager.cpp: (WebCore::AXLiveRegionManager::postAnnouncementForChange): * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::AXObjectCache): (WebCore::AXObjectCache::~AXObjectCache): (WebCore::AXObjectCache::handleAllDeferredChildrenChanged): (WebCore::AXObjectCache::handleChildrenChanged): (WebCore::announcementTranslationTimeoutOverrideForTesting): (WebCore::AXObjectCache::setAnnouncementTranslationTimeoutForTesting): (WebCore::AXObjectCache::announcementTranslationTimeout): (WebCore::AXObjectCache::translateAnnouncementThenAssemble): (WebCore::AXObjectCache::deferReRenderedContent): (WebCore::AXObjectCache::isReRenderedContent const): (WebCore::AXObjectCache::announcementTranslationDidComplete): (WebCore::AXObjectCache::flushPendingAnnouncements): (WebCore::AXObjectCache::scheduleAnnouncementTimeoutTimerIfNeeded): (WebCore::AXObjectCache::pendingAnnouncementTimeoutTimerFired): (WebCore::AXObjectCache::postARIANotifyNotification): * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/editing/TextManipulationController.cpp: (WebCore::TextManipulationController::replace): * Source/WebCore/page/ChromeClient.h: (WebCore::ChromeClient::translateAccessibilityAnnouncementStrings): * Source/WebCore/page/Page.cpp: (WebCore::m_mediaSessionManagerFactory): (WebCore::Page::setDisplayedTranslationLocaleIdentifier): * Source/WebCore/page/Page.h: (WebCore::Page::isPresentingMachineTranslation const): * Source/WebCore/page/PageConfiguration.h: * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::resetToConsistentState): (WebCore::Internals::setAccessibilityAnnouncementTranslationTimeout): * Source/WebCore/testing/Internals.h: * Source/WebCore/testing/Internals.idl: * Source/WebKit/Headers.cmake: * Source/WebKit/PlatformCocoa.cmake: * Source/WebKit/Shared/WebPageCreationParameters.h: * Source/WebKit/Shared/WebPageCreationParameters.serialization.in: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _translateAccessibilityAnnouncementStrings:sourceLocaleIdentifiers:targetLocaleIdentifier:completionHandler:]): (-[WKWebView _translationDelegate]): (-[WKWebView _setTranslationDelegate:]): (-[WKWebView _displayedTranslationLocaleIdentifier]): (-[WKWebView _setDisplayedTranslationLocaleIdentifier:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h: * Source/WebKit/UIProcess/API/Cocoa/_WKTranslationDelegate.h: Added. * Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h: * Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm: (WebKit::PageClientImplCocoa::translateAccessibilityAnnouncementStrings): * Source/WebKit/UIProcess/PageClient.h: (WebKit::PageClient::translateAccessibilityAnnouncementStrings): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::creationParameters): (WebKit::WebPageProxy::displayedTranslationLocaleIdentifier const): (WebKit::WebPageProxy::setDisplayedTranslationLocaleIdentifier): (WebKit::WebPageProxy::translateAccessibilityAnnouncementStrings): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/UIProcess/WebPageProxyInternals.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::translateAccessibilityAnnouncementStrings): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::m_allowsImmersiveEnvironments): (WebKit::WebPage::setDisplayedTranslationLocaleIdentifier): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Tools/TestWebKitAPI/SourcesCocoa.txt: * Tools/TestWebKitAPI/Tests/WebKit/WKWebView/AccessibilityAnnouncementTranslation.mm: Added. (TestWebKitAPI::TEST(AccessibilityAnnouncementTranslation, DisplayedTranslationLocaleRoundTripsAndResetsOnNavigation)): * Tools/WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): (WTR::TestOptions::keyTypeMapping): * Tools/WebKitTestRunner/TestOptions.h: (WTR::TestOptions::announcementTranslationMode const): (WTR::TestOptions::displayedTranslationLocale const): * Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::finishCreatingPlatformWebView): * Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h: * Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: (-[TestRunnerWKWebView initWithFrame:configuration:]): (-[TestRunnerWKWebView _webView:translateAccessibilityAnnouncementStrings:sourceLocaleIdentifiers:targetLocaleIdentifier:completionHandler:]): Canonical link: https://commits.webkit.org/318920@main

webkit-commit-queue · 2026-08-10T20:06:46Z

Committed 318920@main (2b96b32): https://commits.webkit.org/318920@main

Reviewed commits have been landed. Closing PR #71083 and removing active labels.

twilco requested review from AndresGonzalezApple, cdumez, fleizach, minorninth and rniwa as code owners August 6, 2026 21:19

twilco self-assigned this Aug 6, 2026

twilco requested a review from JonWBedard as a code owner August 6, 2026 21:19

twilco added the Accessibility For bugs related to accessibility. label Aug 6, 2026

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 6, 2026

This was referenced Aug 6, 2026

CORE-AAM: Require ariaNotify announcements to be translated when the page is auto-translated w3c/aria#2860

Open

Core-AAM: new UA req that ariaNotify strings should be translated when browser view is auto-translated w3c/core-aam#265

Open

minorninth reviewed Aug 6, 2026

View reviewed changes

twilco force-pushed the eng/AX-Translate-accessibility-announcements-ARIA-Notify-live-regions-when-the-page-is-presented-as-a-machine-translation branch from b6ba13e to 72b2351 Compare August 7, 2026 00:28

twilco requested a review from rr-codes as a code owner August 7, 2026 00:28

twilco force-pushed the eng/AX-Translate-accessibility-announcements-ARIA-Notify-live-regions-when-the-page-is-presented-as-a-machine-translation branch from 72b2351 to 4218643 Compare August 7, 2026 01:52

minorninth approved these changes Aug 10, 2026

View reviewed changes

twilco added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Aug 10, 2026

webkit-commit-queue force-pushed the eng/AX-Translate-accessibility-announcements-ARIA-Notify-live-regions-when-the-page-is-presented-as-a-machine-translation branch from 4218643 to 2b96b32 Compare August 10, 2026 20:06

webkit-commit-queue merged commit 2b96b32 into WebKit:main Aug 10, 2026

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 10, 2026

Navigation Menu

Repository navigation

AX: Translate accessibility announcements (ARIA Notify, live regions) when the page is presented as a machine translation - #71083

twilco commented Aug 6, 2026 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Aug 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

minorninth Aug 6, 2026

Uh oh!

twilco Aug 7, 2026

Uh oh!

minorninth Aug 6, 2026

Uh oh!

twilco Aug 7, 2026 •

edited

Loading

Uh oh!

webkit-ews-buildbot commented Aug 6, 2026

Uh oh!

webkit-ews-buildbot commented Aug 6, 2026

Uh oh!

webkit-early-warning-system commented Aug 7, 2026 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Aug 7, 2026 •

edited

Loading

Uh oh!

webkit-commit-queue commented Aug 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

twilco commented Aug 6, 2026 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2b96b32

Uh oh!

webkit-early-warning-system commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

minorninth Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

twilco Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

minorninth Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

twilco Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-ews-buildbot commented Aug 6, 2026

macOS Safer C++ Build #125800 (b6ba13e)

Uh oh!

webkit-ews-buildbot commented Aug 6, 2026

iOS Safer C++ Build #45784 (b6ba13e)

Uh oh!

webkit-early-warning-system commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Aug 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

twilco commented Aug 6, 2026 •

edited by webkit-early-warning-system

Loading

`2b96b32`

webkit-early-warning-system commented Aug 6, 2026 •

edited

Loading

twilco Aug 7, 2026 •

edited

Loading

macOS Safer C++ Build #125800 (`b6ba13e`)

iOS Safer C++ Build #45784 (`b6ba13e`)

webkit-early-warning-system commented Aug 7, 2026 •

edited

Loading

webkit-early-warning-system commented Aug 7, 2026 •

edited

Loading