WGSL scoping bug hides a duplicate @binding, undersizing the argument buffer and forging a shader device pointer - #78752

9589788

WGSL scoping bug hides a duplicate @binding, undersizing the argument buffer and forging a shader device pointer
https://bugs.webkit.org/show_bug.cgi?id=323904
rdar://186926179

Reviewed by Gerald Squelart.

Visit the declaration before introducing its name in both visitors, and turn the
duplicate-binding ASSERT in determineUsedGlobals into a hard error so a future
divergence between the validator and the rewriter cannot produce a shader whose
argument buffer disagrees with its layout in a release build.

Tests: sar3/fast/webgpu/regression/repro_186926179.html
       sar3/fast/webgpu/regression/shader-module-declaration-scope.html

* LayoutTests/sar3/fast/webgpu/regression/repro_186926179-expected.txt: Added.
* LayoutTests/sar3/fast/webgpu/regression/repro_186926179.html: Added.
* LayoutTests/sar3/fast/webgpu/regression/shader-module-declaration-scope-expected.txt: Added.
* LayoutTests/sar3/fast/webgpu/regression/shader-module-declaration-scope.html: Added.
* Source/WebGPU/WGSL/GlobalSorting.cpp:
(WGSL::GraphBuilder::visit):
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::determineUsedGlobals):
* Source/WebGPU/WGSL/IOValidator.cpp:
(WGSL::IOValidator::visit):
* Tools/TestWebKitAPI/Tests/WGSL/TypeCheckingTests.mm:
(TestWebKitAPI::expectStaticCheckErrorContaining):
(TestWebKitAPI::TEST):

Originally-landed-as: 316606.692@safari-7625-branch (7e32e6e1ffe3). rdar://191050941
Canonical link: https://commits.webkit.org/325176@main

85d2e1e

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-cmake-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	🧪 ios-wk2-wpt	✅ 🧪 api-mac-cmake-debug
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk3-gcc
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-cmake-debug-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-wk2-stress	❌ 🧪 gtk-wk2
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-intel-wk2	✅ 🧪 api-gtk
	❌ 🧪 vision-wk2	✅ 🛠 mac-safer-cpp	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-site-isolation
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim