Skip to content

fix rules issues for update_external_docs workflow - #1606

Merged
UlisesGascon merged 3 commits into
expressjs:gh-pagesfrom
bjohansebas:update-workflow
Oct 6, 2024
Merged

UlisesGascon merged 3 commits into
expressjs:gh-pagesfrom
bjohansebas:update-workflow

Conversation

@bjohansebas

@bjohansebas bjohansebas commented Sep 11, 2024

Copy link
Copy Markdown
Member

Changes are made to run the workflow correctly and prevent this workflow from running in a forked repository.

Changes:

  • Allow the workflow to run manually
  • Now the workflow will only run in the main repository (expressjs/expressjs.com).
  • The tool is updated to use an external action allowed by the organization.
  • Automatically add the review for the @expressjs/docs-wg team.
  • Update the checkout action to its latest version

@netlify

netlify Bot commented Sep 11, 2024

Copy link
Copy Markdown

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit de6afc9
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/67017329cdfe710008db0459
😎 Deploy Preview https://deploy-preview-1606--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas

Copy link
Copy Markdown
Member Author

ping

Comment thread .github/workflows/update-external-docs.yml
@UlisesGascon
UlisesGascon merged commit 24a104a into expressjs:gh-pages Oct 6, 2024
@bjohansebas
bjohansebas deleted the update-workflow branch October 6, 2024 16:31
chrisdel101 pushed a commit to chrisdel101/expressjs.com that referenced this pull request Nov 3, 2024
- Allow the workflow to run manually
- Now the workflow will only run in the main repository (expressjs/expressjs.com).
- The tool is updated to use an external action allowed by the organization.
- Automatically add the review for the @expressjs/docs-wg team.
- Update the checkout action to its latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Sponsor
SponsoredKunjungi sekarang
Promo