Repository navigation
profiler-cli: add a thread list command - #6273
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6273 +/- ##
==========================================
+ Coverage 83.84% 83.90% +0.06%
==========================================
Files 352 353 +1
Lines 37807 37952 +145
Branches 10674 10600 -74
==========================================
+ Hits 31698 31844 +146
Misses 5679 5679
+ Partials 430 429 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
For the same profile (https://share.firefox.dev/4goHeyH), the current The new This doesn't feel perfect to me (I think I would prefer the default sort order to be the thread's start time, so it's possible to find threads that existed at a some something else we are investigating occurred), but already seems better than having no thread list command at all, so if it's not broken, maybe we could do other things as incremental improvements to it. |
canova
left a comment
There was a problem hiding this comment.
Thanks, looks reasonable to me! r+ with some nits.
Nit: Not a huge deal but can you also add this command to the list that we have in README.md?
0beea0c to
fcecdf7
Compare
The only thread inventory was profile info, which sorts by CPU and prints processes rather than a flat table. thread list prints handle, name, process, pid, CPU and marker count for every thread, following counter list, with --sort cpu|index|markers|name, --search and --limit. All rows print by default, as counter list does; a truncated default would reintroduce the discoverability problem profile info has. The marker count is the derived count thread markers reports, not the raw marker-table length -- deriving merges start/end pairs and adds jank markers, so the two differ. thread info reports the raw length, and so disagrees with both.
fcecdf7 to
1fb7b55
Compare
Changes: [fatadel] Show a category breakdown in profiler-cli (#6256) [fatadel] Show allocation data in the cli (#6246) [Florian Quèze] profiler-cli: name the process in the thread banner, and follow the queried thread (#6269) [fatadel] Drive PII sanitization from marker schemas (#6291) [fatadel] Move FileIO table labels into marker schemas (#6296) [Florian Quèze] profiler-cli: add a thread list command (#6273) [Nazım Can Altınova] Update oxfmt 0.63.0 → 0.68.0 (major) (#6316) [Markus Stange] Add missing finishRawMarkerTableBuilder. (#6318) [Markus Stange] Fix the upload error button contrast (#6315) [Markus Stange] Allow typed arrays in the nativeSymbols table (#6300) [Markus Stange] Remove brittle test. (#6322) [Markus Stange] Fix file extension typo. (#6325) [Nazım Can Altınova] Add a permalink command to profiler-cli for already published profiles (#6331) [Markus Stange] Typed arrays + flags for the FuncTable (#6323) [Florian Quèze] profiler-cli: add profile markers for cross-thread marker search (#6276) [fatadel] Convert extension text markers to structured payloads (#6314) [Florian Quèze] profiler-cli: include per-marker fields and data in --list --json (#6275) [Nazım Can Altınova] Add `--with-samply` to "profiler-cli load" (#6339) [Markus Stange] Speed up call tree sidebar by sharing work with the activity graph (#6329) [Nazım Can Altınova] 🔃 Sync: l10n -> main (Sept 22, 2026) (#6341) [Nazım Can Altınova] Bump profiler-cli version to 0.10.0 (#6342) And special thanks to our localizers: el: Jim Spentzos ro: robbp
Main | Deploy preview
The only thread inventory was
profile info, which sorts by CPU and prints processes rather than a flat table.thread listprints handle, name, process, pid, CPU and marker count for every thread, followingcounter list, with --sort cpu|index|markers|name, --search and --limit. All rows print by default, as counter list does; a truncated default would reintroduce the discoverability problem profile info has.The marker count is the derived count thread markers reports, not the raw marker-table length -- deriving merges start/end pairs and adds jank markers, so the two differ. thread info reports the raw length, and so disagrees with both.