Skip to content

unix: support SO_REUSEPORT with load balancing for UDP - #4419

Merged
santigimeno merged 4 commits into
libuv:v1.xfrom
panjf2000:udp-reuseport
Jun 20, 2024
Merged

unix: support SO_REUSEPORT with load balancing for UDP#4419
santigimeno merged 4 commits into
libuv:v1.xfrom
panjf2000:udp-reuseport

Conversation

@panjf2000

@panjf2000 panjf2000 commented May 23, 2024

Copy link
Copy Markdown
Contributor

UDP version of #4407

@panjf2000

panjf2000 commented May 23, 2024

Copy link
Copy Markdown
Contributor Author

/cc @saghul @santigimeno

@panjf2000
panjf2000 force-pushed the udp-reuseport branch 2 times, most recently from 5bec9bc to 6ddb837 Compare May 23, 2024 11:19
@panjf2000

panjf2000 commented May 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This CI failure should have been fixed by #4417

@panjf2000

panjf2000 commented May 27, 2024

Copy link
Copy Markdown
Contributor Author

Kindly ping @saghul @santigimeno

@saghul

saghul commented May 30, 2024

Copy link
Copy Markdown
Member

Merged the test update, can you pl rebase?

@panjf2000

panjf2000 commented May 30, 2024

Copy link
Copy Markdown
Contributor Author

Merged the test update, can you pl rebase?

Done!

@panjf2000

panjf2000 commented May 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

A test failure arose:

not ok 51 - fs_event_error_reporting
# exit code 6
# Output from process `fs_event_error_reporting`:
# Assertion failed in /Users/runner/work/libuv/libuv/test/test-fs-event.c on line 1115: `uv_loop_init(loop) == 0` (-24 == 0)

, with which this PR should have nothing to do (hopefully (⊙ˍ⊙))

santigimeno
santigimeno approved these changes May 30, 2024
View reviewed changes

@santigimeno santigimeno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a couple of comments.

Comment thread test/test-udp-reuseport.c Resolved
Comment thread test/test-udp-reuseport.c Resolved
Comment thread test/test-udp-reuseport.c Resolved
@panjf2000
panjf2000 requested a review from santigimeno May 30, 2024 09:42
@panjf2000

panjf2000 commented May 30, 2024

Copy link
Copy Markdown
Contributor Author

Some comments on this? @saghul

@panjf2000 panjf2000 mentioned this pull request Jun 3, 2024
Merged
saghul
saghul reviewed Jun 3, 2024
View reviewed changes
Comment thread docs/src/udp.rst Resolved
Comment thread include/uv.h Resolved
Comment thread src/unix/core.c Resolved
Comment thread src/unix/udp.c Resolved
@panjf2000
panjf2000 force-pushed the udp-reuseport branch 2 times, most recently from 4220ed3 to e680b8a Compare June 3, 2024 10:34
saghul
saghul approved these changes Jun 3, 2024
View reviewed changes

@saghul saghul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@panjf2000

panjf2000 commented Jun 3, 2024

Copy link
Copy Markdown
Contributor Author

It seems like an irrelevant CI failure:

not ok 321 - tcp_oob
# timeout
# Output from process `tcp_oob`: (no output)

Could you rerun the failed runner manually? @saghul

@saghul

saghul commented Jun 3, 2024

Copy link
Copy Markdown
Member

It seems like an irrelevant CI failure:

not ok 321 - tcp_oob
# timeout
# Output from process `tcp_oob`: (no output)

Could you rerun the failed runner manually? @saghul

Done.

@panjf2000

panjf2000 commented Jun 3, 2024

Copy link
Copy Markdown
Contributor Author

Great! All checks have passed!
Can we get this PR merged now? @saghul

@saghul

saghul commented Jun 3, 2024

Copy link
Copy Markdown
Member

Can we get this PR merged now?

We need some more eyes.

@panjf2000
unix: support SO_REUSEPORT with load balancing for UDP
7e48975 
---------

Signed-off-by: Andy Pan <i@andypan.me>
@panjf2000

panjf2000 commented Jun 3, 2024

Copy link
Copy Markdown
Contributor Author

Maybe @santigimeno wants to take another look at this?

@panjf2000

panjf2000 commented Jun 11, 2024

Copy link
Copy Markdown
Contributor Author

Ping @libuv/collaborators

@panjf2000

panjf2000 commented Jun 19, 2024

Copy link
Copy Markdown
Contributor Author

@santigimeno Could you take a quick look at the latest code changes? Thanks!

santigimeno
santigimeno approved these changes Jun 20, 2024
View reviewed changes

@santigimeno santigimeno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of non-mandatory nits. Sorry it took this long getting to review this: was very busy. Thanks

Comment thread test/test-udp-reuseport.c Resolved
Comment thread src/unix/core.c Resolved
@panjf2000
Resolve some code review comments
3eed01c 
---------

Signed-off-by: Andy Pan <i@andypan.me>
panjf2000 added 2 commits June 20, 2024 11:12
@panjf2000
Undo a few formats
25a2546 
---------

Signed-off-by: Andy Pan <i@andypan.me>
@panjf2000
Update tcp-reuseport
65c9fe4 
---------

Signed-off-by: Andy Pan <i@andypan.me>
@panjf2000
panjf2000 requested a review from santigimeno June 20, 2024 11:45
@santigimeno
santigimeno merged commit ba24986 into libuv:v1.x Jun 20, 2024
@panjf2000
panjf2000 deleted the udp-reuseport branch June 20, 2024 22:17
@theanarkh theanarkh mentioned this pull request Oct 16, 2024
Merged
4 tasks done
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Oct 21, 2024
@theanarkh
lib: add UV_UDP_REUSEPORT for udp
6a02c27 
PR-URL: #55403
Refs: libuv/libuv#4419
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit to nodejs/node that referenced this pull request Oct 23, 2024
@theanarkh @aduh95
lib: add UV_UDP_REUSEPORT for udp
dcbc5fb 
PR-URL: #55403
Refs: libuv/libuv#4419
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit to nodejs/node that referenced this pull request Nov 27, 2024
@theanarkh @ruyadorno
lib: add UV_UDP_REUSEPORT for udp
337f61f 
PR-URL: #55403
Refs: libuv/libuv#4419
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saghul saghul saghul approved these changes
@santigimeno santigimeno santigimeno approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@panjf2000 @saghul @santigimeno