Pre-seed Integrated Browser smoke settings to avoid the relaunch prompt - #328972
Merged
Benjamin Christopher Simmonds (benibenj) merged 1 commit intoAug 4, 2026
Conversation
Setting window.menuStyle through the settings editor made SettingsChangeRelauncher pop a modal 'restart to take effect' dialog on Windows/Linux, which blocked the workbench and broke the first test. Seeding both settings on disk before launch means the values are already in effect when the window opens, so no relaunch prompt appears. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
August 4, 2026 15:04
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
August 4, 2026 15:04
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Pre-seeds Integrated Browser smoke-test settings before startup, preventing Linux/Windows relaunch prompts.
Changes:
- Moves required settings from runtime editor updates to
settings.json. - Documents why custom menus must be pinned.
Show a summary per file
| File | Description |
|---|---|
test/smoke/src/areas/browserView/browserView.test.ts |
Seeds browser settings in the pre-start hook. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Benjamin Christopher Simmonds (benibenj)
disabled auto-merge
August 4, 2026 15:08
Henning Dieterichs (hediet)
approved these changes
Aug 4, 2026
Contributor
Paul (pwang347)
approved these changes
Aug 4, 2026
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
August 4, 2026 15:21
Benjamin Christopher Simmonds (benibenj)
merged commit Aug 4, 2026
df53daa
into
release/1.132
29 of 30 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
benibenj/fix-browser-smoke-relaunch-prompt
branch
August 4, 2026 15:30
Benjamin Christopher Simmonds (benibenj)
added a commit
that referenced
this pull request
Aug 4, 2026
…ies (#328983) The suite drives the browser toolbar overflow and Add to Chat menus through HTML locators (.monaco-menu-container). On macOS, stable defaults window.menuStyle to 'native' while insiders defaults to 'inherit', so those menus render as native OS menus in stable and the locators never resolve. Pin the setting to 'custom' for the suite, seeded on disk before startup. Writing it at runtime instead would make SettingsChangeRelauncher pop a modal 'restart to take effect' dialog on Windows/Linux, blocking the workbench. Ports #328969 and #328972 from release/1.132 to main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #328969, which is already merged.
That PR pinned
window.menuStyletocustomfor theIntegrated Browsersuite by writing it through the settings editor. That fixed the macOS stable/insiders divergence, but it introduced a new failure on Linux CI in the very first test:Cause
window.menuStyleis watched bySettingsChangeRelauncher, which on Windows/Linux treats a change to it as requiring a restart:Writing the setting at runtime therefore popped a modal dialog ("A setting has changed that requires a restart to take effect.") over the workbench. The quick input was still in the DOM, but obscured by the modal, so
fillnever became possible. This was a real regression, not flakiness — it is deterministic on Windows/Linux, and it does not reproduce on macOS because the relauncher deliberately skipsmenuStylethere.Fix
Seed both settings into
settings.jsonbefore the application starts, in the existingbeforeStarthook, instead of writing them once the window is up:workbench.browser.experimentalUserTools.enabledmoves with it — it is declaredexperiment: { mode: 'startup' }, so it is better applied at startup anyway.The reason for pinning
customis unchanged and is now captured in a comment on the helper. The underlying question of what the default should be is tracked in #328970.