Repository navigation
src: tag v8 aligned pointer slots with embedder data type tags - #60602
Conversation
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60602 +/- ##
==========================================
- Coverage 88.56% 88.54% -0.03%
==========================================
Files 704 704
Lines 208077 208085 +8
Branches 40084 40082 -2
==========================================
- Hits 184289 184253 -36
- Misses 15826 15867 +41
- Partials 7962 7965 +3
🚀 New features to boost your workflow:
|
joyeecheung
left a comment
There was a problem hiding this comment.
RSLGTM. I feel that it'd be nicer to add a method to BaseObject that allows setting arbitrary slot with the tag so that we don't have to repeat the default argument in all its subclasses, but that can be a followup
Many of the changed lines in this PR are not in the subclasses of |
|
Landed in b8e264d |
|
Build failure on v25.x-staging: |
|
Sorry, it should not land on v25.x |
* support_v8_sandboxed_pointers.patch Ref: nodejs/node#62237 * refactor_attach_cppgc_heap_on_v8_isolate_creation.patch Ref: nodejs/node#58070 * test_accomodate_v8_thenable_stack_trace_change_in_snapshot.patch Ref: nodejs/node#59805 * api_remove_deprecated_getisolate.patch Ref: nodejs/node#59805 Ref: nodejs/node#60223 * api_delete_deprecated_fields_on_v8_isolate.patch Ref: nodejs/node#60488 * api_promote_deprecation_of_v8_context_and_v8_object_api_methods.patch Ref: nodejs/node#60602 * src_refactor_module_wrap_cc_to_update_fixedarray_get_params.patch Ref: nodejs/node#61898 * src_refactor_wasmstreaming_finish_to_accept_a_callback.patch Ref: nodejs/node#61898 * src_stop_using_v8_propertycallbackinfo_t_this.patch Ref: nodejs/node#61898 * fix_add_externalpointertypetag_to_v8_external_api_calls.patch Ref: nodejs/node#61898 * src_stop_using_removed_v8_promise_reject_events.patch Ref: nodejs/node#62336 * src_backport_the_perfetto_trace_agent.patch Ref: nodejs/node#64565 Ref: nodejs/node#64721 * test_account_for_libc_rm_error_on_electron_linux.patch Ref: nodejs/node#66065 * fix_do_not_pass_removed_jspi_v8_flag.patch Ref: nodejs/node#60014 * test_drop_removed_wasm_rab_integration_flag.patch The v26 version of nodejs/node#65845 never added the flag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU
Fixes: #60589