fix(formatter): keep comments between a head and its body out of the braces across all constructs - #26071
Merged
Conversation
Member
Author
This was referenced Aug 25, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
leaysgur
force-pushed
the
08-25-fix_formatter_keep_comments_between_a_head_and_its_body_out_of_the_braces_across_all_constructs
branch
from
August 25, 2026 04:29
d3942fd to
e7ee08b
Compare
leaysgur
force-pushed
the
08-24-fix_formatter_place_comments_between_a_head_and_open_paren
branch
from
August 25, 2026 04:29
fec3425 to
b1dd6f0
Compare
leaysgur
force-pushed
the
08-24-fix_formatter_place_comments_between_a_head_and_open_paren
branch
from
August 25, 2026 05:02
b1dd6f0 to
fe36ab6
Compare
leaysgur
force-pushed
the
08-25-fix_formatter_keep_comments_between_a_head_and_its_body_out_of_the_braces_across_all_constructs
branch
from
August 25, 2026 05:02
e7ee08b to
af4ca9f
Compare
This was referenced Aug 25, 2026
Contributor
Merge activity
|
…braces across all constructs (#26071) Fix inconsisntet and also non-idempotent formatting around: ```js m3(tagName: string, rect: number[]): void // THIS should stay { // ... } ```
graphite-app
Bot
force-pushed
the
08-24-fix_formatter_place_comments_between_a_head_and_open_paren
branch
from
August 25, 2026 09:29
fe36ab6 to
57537a2
Compare
graphite-app
Bot
force-pushed
the
08-25-fix_formatter_keep_comments_between_a_head_and_its_body_out_of_the_braces_across_all_constructs
branch
from
August 25, 2026 09:30
af4ca9f to
3bbcea6
Compare
Base automatically changed from
08-24-fix_formatter_place_comments_between_a_head_and_open_paren
to
main
August 25, 2026 09:34
graphite-app
Bot
deleted the
08-25-fix_formatter_keep_comments_between_a_head_and_its_body_out_of_the_braces_across_all_constructs
branch
August 25, 2026 09:34
graphite-app Bot
pushed a commit
that referenced
this pull request
Sep 1, 2026
# Oxlint ### 🚀 Features - 60b945d linter/nextjs/no-typos: Implement suggestion (#26091) (Mikhail Baev) ### 🐛 Bug Fixes - 33ac4b0 linter/lsp: Prevent tsgolint from holding onto processes (#25570) (Adrian Schaedle) - baf4b1e linter/import/no-empty-named-blocks: Make empty value import removal a suggestion (#26155) (camc314) - 77cfaec linter/eslint/object-shorthand: Preserve `__proto__` semantics (#26154) (camc314) - fa3c082 linter/unicorn/prefer-set-size: Ignore shadowed `Set` constructors (#26153) (camc314) - e412cf2 linter: Clamp invalid JS plugin locations (#26144) (camc314) - d86c113 linter: Normalize reversed JS plugin locations (#26138) (camc314) - 73c09b2 linter/eslint/no-use-before-define: Run on JS, JSX files (#26114) (camc314) - 03ef0f2 linter/unicorn/no-useless-spread: Treat typed arrays as a distinct value hint (#26067) (Aadharsh Pannirselvam) - bd15905 linter/react/no-unstable-nested-components: Check nested component object property names (#26101) (camc314) - 3910e2b linter/eslint/no-unassigned-vars: Skip Svelte and Vue files (#26042) (Hamody We) - 047f7ca linter/plugins: Fix interaction between JS plugins and Vue rules (#26080) (overlookmotel) - 8531b9b linter/plugins: Alter method for obtaining mutable `Program` when sending AST to JS plugins (#26077) (overlookmotel) - dc464ff linter/unicorn/prefer-math-min-max: Avoid unsafe autofix (#26060) (camc314) ### 📚 Documentation - 464ddd1 linter: Support a shared short description for jest/vitest rules (#26186) (connorshea) - 9db5ad3 linter: Add short description to `vue/no-dupe-keys` (#26183) (connorshea) - db66f58 linter: Correct export/import mismatch in bar and foo example (#25927) (billychannnnnn) - d5be037 linter/typescript/switch-exhaustiveness-check: Clarify default case comment pattern (#26100) (camc314) # Oxfmt ### 🚀 Features - 1fb37b6 formatter/css: Format declaration-shaped raw-prelude rules (postcss nested config blocks) (#26194) (leaysgur) ### 🐛 Bug Fixes - 57e8e22 formatter_css: Space a folded sign after a call in Less operations (#26134) (leaysgur) - e4298fb formatter/jsdoc: Follow CommonMark for interrupting lists and guard wrapping from creating them (#26098) (leaysgur) - a1e21c2 formatter: Apply head body policy everywhere (#26074) (leaysgur) - 676b7e1 formatter: Keep comments in their for-head slot, before an empty-statement body and do-while (#26073) (leaysgur) - 3bbcea6 formatter: Keep comments between a head and its body out of the braces across all constructs (#26071) (leaysgur) - 57537a2 formatter: Place comments between a head and open paren (#26058) (leaysgur) - e2d53e7 formatter: Place comments between a statement head and its body (#26043) (leaysgur) - 662556c formatter: Print the idempotent placement for comments in dropped parens (#26041) (leaysgur) - faf11d9 formatter_yaml: Keep trailing whitespace in block scalars (#26072) (leaysgur) ### ⚡ Performance - ac4785a diagnostics: Use fixed ANSI styles (#26130) (Boshen) ### 📚 Documentation - b879608 formatter,formatter_graphql,formatter_yaml: Annotate own-line comment inlining as known policy violation (#26131) (leaysgur) - 181953b oxfmt,formatter_core,formatter,formatter_yaml,formatter_css,formatter_graphql: Extract `DIVERGENCES.md` out from `AGENTS.md` (#26121) (leaysgur) - a67cb9d formatter,formatter_core: Document comment moving policy (#26075) (leaysgur) - fc175b0 formatter_core: Clarify idempotency test infra (#26069) (leaysgur)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix inconsisntet and also non-idempotent formatting around: