Skip to content

fix(formatter): print suppressed typecast parens - #26218

Merged
graphite-app[bot] merged 1 commit into
mainfrom
09-01-fix_formatter_print_suppressed_typecast_parens
Sep 1, 2026
Merged

fix(formatter): print suppressed typecast parens#26218
graphite-app[bot] merged 1 commit into
mainfrom
09-01-fix_formatter_print_suppressed_typecast_parens

Conversation

@leaysgur

@leaysgur leaysgur commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member 
// input
foo(
  // oxfmt-ignore
  /** @type {A} */ (x),
  /** @type {B} */ (y),
);

// before
foo(
  // oxfmt-ignore
  /** @type {A} */ x, // <-
  /** @type {B} */ (y),
);

// after
foo(
  // oxfmt-ignore
  /** @type {A} */ (x), // <-
  /** @type {B} */ (y),
);

@leaysgur Graphite App

leaysgur commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-ast-tools Area - AST tools A-formatter Area - Formatter labels Sep 1, 2026
@codspeed

codspeed Bot commented Sep 1, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 19 skipped benchmarks1

Comparing 09-01-fix_formatter_print_suppressed_typecast_parens (3d0c670) with main (5ff57f8)

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@leaysgur leaysgur mentioned this pull request Sep 1, 2026
Merged
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Sep 1, 2026
@graphite-app

graphite-app Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@leaysgur
fix(formatter): print suppressed typecast parens (#26218)
769ffd5 
```js
// input
foo(
  // oxfmt-ignore
  /** @type {A} */ (x),
  /** @type {B} */ (y),
);

// before
foo(
  // oxfmt-ignore
  /** @type {A} */ x, // <-
  /** @type {B} */ (y),
);

// after
foo(
  // oxfmt-ignore
  /** @type {A} */ (x), // <-
  /** @type {B} */ (y),
);
```
@graphite-app
graphite-app Bot force-pushed the 09-01-fix_formatter_print_suppressed_typecast_parens branch from 3d0c670 to 769ffd5 Compare September 1, 2026 07:25
@graphite-app
graphite-app Bot merged commit 769ffd5 into main Sep 1, 2026
31 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Sep 1, 2026
@graphite-app
graphite-app Bot deleted the 09-01-fix_formatter_print_suppressed_typecast_parens branch September 1, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees

No one assigned

Labels

A-ast-tools Area - AST tools A-formatter Area - Formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leaysgur
Sponsor
SponsoredKunjungi sekarang
Promo