fix(transformer): gate async-only rewrites by owning transform - #26326
Merged
graphite-app[bot] merged 1 commit intoSep 7, 2026
Merged
Conversation
This was referenced Sep 4, 2026
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Dunqing
force-pushed
the
codex/fix-transformer-arguments-capture-boundary
branch
from
September 7, 2026 04:00
edbe229 to
b56b3bf
Compare
Dunqing
force-pushed
the
codex/fix-transformer-async-rewrite-boundary
branch
3 times, most recently
from
September 7, 2026 04:07
56ca70e to
5bfd136
Compare
Dunqing
force-pushed
the
codex/fix-transformer-arguments-capture-boundary
branch
from
September 7, 2026 04:07
b56b3bf to
5a74165
Compare
Dunqing
marked this pull request as ready for review
September 7, 2026 06:28
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
graphite-app
Bot
changed the base branch from
codex/fix-transformer-arguments-capture-boundary
to
graphite-base/26326
September 7, 2026 07:05
graphite-app
Bot
force-pushed
the
graphite-base/26326
branch
from
September 7, 2026 07:11
5a74165 to
f45a9ee
Compare
graphite-app
Bot
force-pushed
the
codex/fix-transformer-async-rewrite-boundary
branch
from
September 7, 2026 07:11
5bfd136 to
e146965
Compare
graphite-app
Bot
force-pushed
the
codex/fix-transformer-async-rewrite-boundary
branch
from
September 7, 2026 07:12
e146965 to
491df8e
Compare
Contributor
Merge activity
|
For targets that support async functions but not async generators, async-only converter mode still treated every async function as if the enabled transform would move its body. Plain async arrows and methods gained generated `this` and `super` bindings, and class-field arrows were wrapped unnecessarily.
Use the shared body-movement predicate for every async-only rewrite. Functions left native by the selected target now remain untouched, while async generator functions that are lowered keep their required lexical captures.
## Example
A plain async method using `super` previously gained a generated `_superprop_getValue` binding even though the method remained native. This made `eval("typeof _superprop_getValue")` return `"function"` instead of `"undefined"`. The method now remains unchanged.
Verified with focused output/runtime conformance, full transformer output conformance, and `cargo test -p oxc_transformer`.
Stacked on #26317.
AI assistance was used to diagnose the remaining transform boundaries, implement the predicate checks, and add tests. I remain responsible for reviewing and understanding the changes before merge.
graphite-app
Bot
force-pushed
the
codex/fix-transformer-async-rewrite-boundary
branch
from
September 7, 2026 07:21
491df8e to
3d95477
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Sep 7, 2026
Oxc Transformer supports output down to ES2015, but the contributor guidance did not state that floor and the Rust API docs still listed `es5`. This made plugin-only transform combinations look like supported target configurations. Document the ES2015 floor and require target-dependent regressions to be reproducible through public target selection. Legacy runtime targets may still select available transforms, but do not imply complete compatibility with pre-ES2015 engines. Stacked on #26326. Verified with `cargo fmt --check`, `just doc`, and `cargo test -p oxc_transformer`. `just ready` completed formatting and workspace checks, but stopped in the test phase on the existing Node-version-only `stacktrace_is_correct` snapshot difference (`v25.8.1` locally versus `v26.5.0` recorded). AI assistance was used to investigate the documentation gap, edit the guidance, and run verification. I remain responsible for reviewing and understanding the changes before merge.
graphite-app
Bot
deleted the
codex/fix-transformer-async-rewrite-boundary
branch
September 7, 2026 07:27
graphite-app Bot
pushed a commit
that referenced
this pull request
Sep 7, 2026
### 💥 BREAKING CHANGES - 66744f0 parser: [**BREAKING**] Rename `panicked` to `fatal_error` in `ParserReturn` (#26382) (overlookmotel) - 2c9a947 parser: [**BREAKING**] Reduce `MAX_LEN` to 256 bytes below `u32::MAX` (#26352) (overlookmotel) ### 🚀 Features - 32bdc5b allocator: Construct `ArenaHashSet` with any `Default` hasher (#26372) (Dunqing) - a17de58 minifier: Process of return/throw in non last position and fix async * inlining (#26214) (Armano) - bfb4c57 parser: Distinguish unapplied no-side-effects comments (#26120) (碳苯 Carbon) - 1d9b9d3 ast: Add `GetNodeId` trait (#26145) (camc314) ### 🐛 Bug Fixes - b156333 codegen: Order accessibility before abstract on accessors (#26392) (camc314) - 116c8b8 transformer/class-properties: Keep private methods in class-expression scope (#26308) (Changsu Seong) - 1400a0f parser: Require a string source after `export ... from` (#26389) (camc314) - 2da73b7 codegen: Print matching quoted import names as identifiers (#26386) (camc314) - 0a81d29 codegen: Preserve private-in left operand precedence (#26383) (camc314) - 9a02337 parser: Correctly round large nondecimal literals (#26379) (camc314) - 3d95477 transformer: Gate async-only rewrites by owning transform (#26326) (Dunqing) - f45a9ee transformer: Limit arguments capture to lowered async functions (#26317) (Dunqing) - 789969f transformer: Gate this capture by owning async transform (#26227) (Dunqing) - affeb14 minifier: Mangle class private members in Node API (#26118) (碳苯 Carbon) - 8b35abd semantic: Detect duplicate private class elements (#26361) (camc314) - 457ed57 semantic: Reject await and yield in rest parameter defaults (#26359) (camc314) - 4b89c7b semantic: Reject jumps across arrow functions (#26357) (camc314) - c966aca parser: Do not omit `<` token opening type argument list (#26328) (overlookmotel) - f07dca5 ast_visit: Add the trimmed prefix length to translation table offsets (#26173) (Bharadwaj Pendyala) - 3ab9bd1 parser: Do not re-lex template substitution tail after fatal error (#26230) (overlookmotel) - 07851b9 parser: Fix debug assert failure when lexer error with tokens enabled (#26229) (overlookmotel) - 00dea7a allocator: Gate `Allocator::data_end_ptr` behind fixed_size feature (#26248) (camc314) - 853ffab ecmascript: Avoid `charAt` panic on 32-bit (#26244) (camc314) - 34feccb runtime: Remove stale regenerator exports (#26243) (camc314) ### ⚡ Performance - 34a242e minifier: Use `Ident` for property mangler (#26334) (sapphi-red) - 5303f5c minifier: Unify merging of last expression into target sequence (#26264) (Armano) - 2ca7d29 minifier: Consume nodes in minimize_statements in reverse order (#26258) (Armano) - d2354b4 mangler: Use `Ident` for variable names to keep (#26333) (sapphi-red) - 5b3e335 minifier: Use `Ident` instead of `Str` in `KeepVar` (#26332) (sapphi-red) - 51366fb minifier: Use `IdentHashSet` in `PrivateMemberUsageStack` (#26331) (sapphi-red) - d19c42a minifier: Merge nested if stmt in place instead of creating dummies (#26351) (Armano) - 356def6 parser: Shrink annotation comment ranges (#26356) (overlookmotel) - a5be474 parser: Shave instruction off `parse_jsx_element_name` (#26355) (overlookmotel) - 9780663 parser: Remove fatal error guard from `parse_jsx_element_name` (#26354) (overlookmotel) - 766e12f parser: Remove `token` field from `LexerCheckpoint` (#26350) (overlookmotel) ### 📚 Documentation - d4b4e61 transformer: Document ES2015 target floor (#26378) (Dunqing) - 67dd054 ast_visit: Correct out-of-date comments on `Utf8ToUtf16` converter (#26285) (overlookmotel) - a8ed2a7 minifier: Fix stale validation instructions (#26251) (camc314)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For targets that support async functions but not async generators, async-only converter mode still treated every async function as if the enabled transform would move its body. Plain async arrows and methods gained generated
thisandsuperbindings, and class-field arrows were wrapped unnecessarily.Use the shared body-movement predicate for every async-only rewrite. Functions left native by the selected target now remain untouched, while async generator functions that are lowered keep their required lexical captures.
Example
A plain async method using
superpreviously gained a generated_superprop_getValuebinding even though the method remained native. This madeeval("typeof _superprop_getValue")return"function"instead of"undefined". The method now remains unchanged.Verified with focused output/runtime conformance, full transformer output conformance, and
cargo test -p oxc_transformer.Stacked on #26317.
AI assistance was used to diagnose the remaining transform boundaries, implement the predicate checks, and add tests. I remain responsible for reviewing and understanding the changes before merge.