don't forget scope-expressions on $this after static method call #13735

Activity

1. ondrejmirtes commented on Oct 29, 2025

   

   ondrejmirtes

   on Oct 29, 2025

   Member

   More actions

   But only for properties on $this.

   If we were talking about $this->getFoo() method, the method itself could reference a static property in its body, so self::assertTrue() still needs to invalidate $this->getFoo().
2. staabm commented on Oct 29, 2025

   

   staabm

   on Oct 29, 2025

   ContributorAuthor

   More actions

   But only for properties on $this.

   good point. the repro in phpstan/phpstan-phpunit#229 contains a static property access.. so this fix here would not fix the phpstan-phpunit bug
3. staabm commented on Oct 30, 2025

   

   staabm

   on Oct 30, 2025

   Last edited by staabm

   ContributorAuthor

   More actions

   But only for properties on $this.

   but also for private properties on self::?

           \PHPStan\dumpType(self::$mockServer); // Dumped type: donatj\MockWebServer\MockWebServer   
           self::assertTrue(self::$mockServer->isRunning());
           \PHPStan\dumpType(self::$mockServer); // Dumped type: donatj\MockWebServer\MockWebServer|null      
   
4. ondrejmirtes

   added

   bug

   on Feb 5, 2026
5. ondrejmirtes

   added this to the Easy fixes milestone on Feb 5, 2026
6. phpstan-bot

   added a commit that references this issue on Mar 31, 2026

   Fix phpstan/phpstan#13735: Don't forget $this property types after st…

   ...

   This issue will close once commit 17b5748 is merged into the '2.2.x' branch.

   17b5748
7. staabm commented on Sep 7, 2026

   

   staabm

   on Sep 7, 2026

   ContributorAuthor

   More actions

   another repro https://phpstan.org/r/20f51e02-6d5f-421a-8797-0286f63a45fb
8. phpstan-bot

   added a commit that references this issue on Sep 8, 2026

   Keep property fetches on the receiver when a static method or static …

   ...

   91db796
9. staabm

   closed this as completedin phpstan-src#6391on Sep 8, 2026
10. github-actions commented on Oct 10, 2026

    

    github-actionsBot

    on Oct 10, 2026 – with GitHub Actions

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
11. github-actions

    locked as resolved and limited conversation to collaborators on Oct 10, 2026