Skip to content

Print exit code if rustc fails in compiletest - #164351

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mati865:compiletest-rustc-exit-code
Oct 15, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mati865:compiletest-rustc-exit-code

Conversation

@mati865

@mati865 mati865 commented Oct 15, 2026

Copy link
Copy Markdown
Member

In rare instances when rustc is broken, the exit code is the only feedback that we can get.
Example of such case #157712 (comment).

@rustbot

rustbot commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added the A-compiletest Area: The compiletest test runner label Oct 15, 2026
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 15, 2026
@rustbot

rustbot commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
  • @jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu, oli-obk

Comment thread src/tools/compiletest/src/common.rs Resolved
@mati865
mati865 force-pushed the compiletest-rustc-exit-code branch from 11759c4 to febb9f2 Compare October 15, 2026 10:26
Comment thread src/tools/compiletest/src/common.rs Resolved
@mati865

mati865 commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

@bors squash

@rust-bors

This comment has been minimized.

* Print exit code if rustc fails in compiletest
* Update src/tools/compiletest/src/common.rs

Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
@rust-bors

rust-bors Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

🔨 2 commits were squashed into 6708173.

@rust-bors
rust-bors Bot force-pushed the compiletest-rustc-exit-code branch from a6fa185 to 6708173 Compare October 15, 2026 10:40
@jieyouxu

Copy link
Copy Markdown
Member

Thanks
@bors r=bjorn3,jieyouxu rollup

@rust-bors

rust-bors Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 6708173 has been approved by bjorn3,jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 15, 2026
…uwer

Rollup of 2 pull requests

Successful merges:

 - #164332 (Skip move checks when the size limit is zero)
 - #164351 (Print exit code if rustc fails in compiletest)
@rust-bors
rust-bors Bot merged commit f77e393 into rust-lang:main Oct 15, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 15, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 15, 2026
Rollup merge of #164351 - mati865:compiletest-rustc-exit-code, r=bjorn3,jieyouxu

Print exit code if rustc fails in compiletest

In rare instances when rustc is broken, the exit code is the only feedback that we can get.
Example of such case #157712 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants