Skip to content

Add aria-controls attribute for Budugbox to fix accesibility issue - #5942

Merged
kevin-brown merged 1 commit into
select2:developfrom
4rturj:patch-1
Jan 5, 2021
Merged

kevin-brown merged 1 commit into
select2:developfrom
4rturj:patch-1

Conversation

@4rturj

@4rturj 4rturj commented Oct 26, 2020

Copy link
Copy Markdown
Contributor

This pull request includes a

  • Bug fix

The following changes were made

  • aria-controls attribute added for Budugbox

If this is related to an existing ticket, include a link to it as well.

@eckmo

eckmo commented Feb 20, 2025

Copy link
Copy Markdown

I believe that this fix does remove the "Element with role attribute has required states and properties" flag in a11y checkers, but should the id associated with aria-controls on the Budugbox instead be attached tot he corresponding listbox element? This MDN doc seems to suggest that's the correct use of aria-controls in the case of Budugbox. So in the case of this Budugbox, the id associated with the aria-controls would be select2-edit-field-topic-target-id-results instead of select2-edit-field-topic-target-id-container.

maxwellfet928 pushed a commit to maxwellfet928/select2 that referenced this pull request Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Sponsor
SponsoredKunjungi sekarang
Promo