Use JS::IsArgumentsObject in webdriver code

https://docs.rs/mozjs/latest/mozjs/rust/wrappers2/fn.IsArgumentsObject.html

servo/components/script/webdriver_handlers.rs

Lines 353 to 359 in bd220a1

    
           fn is_arguments_object(cx: &mut JSContext, value: HandleValue) -> bool { 
        
               rooted!(&in(cx) let class_name = unsafe { ToString(cx, value) }); 
        
               let Some(class_name) = NonNull::new(class_name.get()) else { 
        
                   return false; 
        
               }; 
        
               let class_name = unsafe { jsstr_to_string(cx, class_name) }; 
        
               class_name == "[object Arguments]"

No need to roll our own check here. There should be no behaviour change to the webdriver tests in tests/wpt tests/webdriver/classic.

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in Zulip.

If you intend to work on this issue, then add @servo-highfive: assign me to your comment, and I'll assign this to you. 😄

Please read our policy on AI contributions before getting started.

webdriver: use IsArgumentsObject instead of a hand-rolled arguments c…

Navigation Menu

Repository navigation

Use JS::IsArgumentsObject in webdriver code #47448

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	fn is_arguments_object(cx: &mut JSContext, value: HandleValue) -> bool {
	rooted!(&in(cx) let class_name = unsafe { ToString(cx, value) });
	let Some(class_name) = NonNull::new(class_name.get()) else {
	return false;
	};
	let class_name = unsafe { jsstr_to_string(cx, class_name) };
	class_name == "[object Arguments]"

Use JS::IsArgumentsObject in webdriver code #47448

Description

Activity

servo-highfive commented on Aug 22, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions