Repository navigation
webdriver: use IsArgumentsObject instead of a hand-rolled arguments check - #47514
Merged
Merged
Conversation
…heck Signed-off-by: Leo Cheng <chengkelfan@qq.com>
jdm
enabled auto-merge
August 25, 2026 13:40
Contributor
Author
|
👍
|
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
…heck (servo#47514) Replaces the hand-rolled `[object Arguments]` string comparison in `is_arguments_object` with the `IsArgumentsObject` wrapper from mozjs, as suggested in the issue. No behaviour change is expected, so the existing `tests/wpt tests/webdriver/classic` tests should be unaffected and no new tests are added. Fixes servo#47448 Signed-off-by: Leo Cheng <chengkelfan@qq.com>
Psychpsyo
pushed a commit
to Psychpsyo/servo
that referenced
this pull request
Oct 12, 2026
…heck (servo#47514) Replaces the hand-rolled `[object Arguments]` string comparison in `is_arguments_object` with the `IsArgumentsObject` wrapper from mozjs, as suggested in the issue. No behaviour change is expected, so the existing `tests/wpt tests/webdriver/classic` tests should be unaffected and no new tests are added. Fixes servo#47448 Signed-off-by: Leo Cheng <chengkelfan@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the hand-rolled
[object Arguments]string comparison inis_arguments_objectwith theIsArgumentsObjectwrapper from mozjs, as suggested in the issue.No behaviour change is expected, so the existing
tests/wpt tests/webdriver/classictests should be unaffected and no new tests are added.Fixes #47448