Repository navigation
Fix #2909 (squashed version of PR #24865) - #24870
Merged
Merged
Conversation
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @ferjm (or someone else) soon. |
|
Heads up! This PR modifies the following files:
|
4 of 5 tasks
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit 7363db3 has been approved by |
Member
|
Looks good, thanks! I’ve edited the PR description to not auto-close #2909. |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Nov 27, 2019
Fix #2909 (squashed version of PR #24865) <!-- Please describe your changes on the following line: --> Now using data-url::forgiving_base64 instead of base64, this fixes all the fetch/data-urls/base64.* tests. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not quite fix yet #2909 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Contributor
|
💔 Test failed - status-taskcluster |
Member
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Nov 27, 2019
Fix #2909 (squashed version of PR #24865) <!-- Please describe your changes on the following line: --> Now using data-url::forgiving_base64 instead of base64, this fixes all the fetch/data-urls/base64.* tests. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not quite fix yet #2909 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Contributor
|
☀️ Test successful - status-taskcluster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now using data-url::forgiving_base64 instead of base64, this fixes all the fetch/data-urls/base64.* tests.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors