Repository navigation
layout: Make lines non-phantom if they have inline padding/border/margin - #39058
Merged
Merged
Conversation
|
🔨 Triggering try run (#17363522120) for Linux (WPT) |
|
Test results for linux-wpt from try job (#17363522120): Flaky unexpected result (23)
Stable unexpected results that are known to be intermittent (24)
Stable unexpected results (2)
|
|
|
Loirooriol
force-pushed
the
phantom-lines-pbm
branch
from
September 1, 2025 13:30
795add3 to
4b3ff4d
Compare
|
🔨 Triggering try run (#17379148533) for Linux (WPT) |
|
Test results for linux-wpt from try job (#17379148533): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (26)
|
|
✨ Try run (#17379148533) succeeded. |
Loirooriol
force-pushed
the
phantom-lines-pbm
branch
from
September 14, 2025 03:35
4b3ff4d to
1a8665b
Compare
|
🔨 Triggering try run (#17705897277) for Linux (WPT) |
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#54833) with upstreamable changes. |
|
Test results for linux-wpt from try job (#17705897277): Flaky unexpected result (22)
Stable unexpected results that are known to be intermittent (24)
|
|
✨ Try run (#17705897277) succeeded. |
|
🔨 Triggering try run (#17708592155) for Linux (WPT) |
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#54833). |
|
Test results for linux-wpt from try job (#17708592155): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (31)
|
|
✨ Try run (#17708592155) succeeded. |
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#54833) title and body. |
Loirooriol
force-pushed
the
phantom-lines-pbm
branch
from
September 14, 2025 08:53
9a0bde1 to
9f601a8
Compare
|
🔨 Triggering try run (#17708950512) for Linux (WPT) |
Loirooriol
marked this pull request as ready for review
September 14, 2025 08:56
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#54833). |
|
Test results for linux-wpt from try job (#17708950512): Flaky unexpected result (41)
Stable unexpected results that are known to be intermittent (26)
|
|
✨ Try run (#17708950512) succeeded. |
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#54833) title and body. |
mrobinson
approved these changes
Sep 16, 2025
According to https://drafts.csswg.org/css-inline/#invisible-line-boxes, if a line box contains non-zero inline-axis margins, padding or borders, then it can't be phantom. Therefore, this patch makes adds a `has_inline_pbm` flag to the line. Note that we can't use the `has_content` flag, because that would add a soft wrap wrap opportunity between the padding/border/margin and the first content of the line. The patch also renames `InlineFormattingContext::had_inflow_content` to `has_line_boxes`, which is what we care about for collapsing margins through. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Loirooriol
force-pushed
the
phantom-lines-pbm
branch
from
September 16, 2025 21:35
9f601a8 to
c93cf1b
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#54833). |
Loirooriol
enabled auto-merge
September 16, 2025 21:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://drafts.csswg.org/css-inline/#invisible-line-boxes, if a line box contains non-zero inline-axis margins, padding or borders, then it can't be phantom.
Therefore, this patch makes adds a
has_inline_pbmflag to the line. Note that we can't use thehas_contentflag, because that would add a soft wrap opportunity between the padding/border/margin and the first content of the line.The patch also renames
InlineFormattingContext::had_inflow_contenttohas_line_boxes, which is what we care about for collapsing margins through.Testing: Adding new tests
Fixes: #39057