Repository navigation
layout: Make lines non-phantom if they have inline padding/border/margin - #54833
Merged
servo-wpt-sync merged 1 commit intoSep 16, 2025
Merged
Conversation
wpt-pr-bot
approved these changes
Sep 14, 2025
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_39058
branch
2 times, most recently
from
September 14, 2025 08:56
12482d4 to
88c1de7
Compare
According to https://drafts.csswg.org/css-inline/#invisible-line-boxes, if a line box contains non-zero inline-axis margins, padding or borders, then it can't be phantom. Therefore, this patch makes adds a `has_inline_pbm` flag to the line. Note that we can't use the `has_content` flag, because that would add a soft wrap wrap opportunity between the padding/border/margin and the first content of the line. The patch also renames `InlineFormattingContext::had_inflow_content` to `has_line_boxes`, which is what we care about for collapsing margins through. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
servo-wpt-sync
force-pushed
the
servo_export_39058
branch
from
September 16, 2025 21:38
88c1de7 to
2f0585d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://drafts.csswg.org/css-inline/#invisible-line-boxes, if a line box contains non-zero inline-axis margins, padding or borders, then it can't be phantom.
Therefore, this patch makes adds a
has_inline_pbmflag to the line. Note that we can't use thehas_contentflag, because that would add a soft wrap opportunity between the padding/border/margin and the first content of the line.The patch also renames
InlineFormattingContext::had_inflow_contenttohas_line_boxes, which is what we care about for collapsing margins through.Testing: Adding new tests
Fixes: #39057
Reviewed in servo/servo#39058