Repository navigation
layout: Pass poster_url for LargestContentfulPaint Entry - #43376
Merged
Merged
Conversation
shubhamg13
requested review from
Loirooriol,
gterzian and
mrobinson
as code owners
March 18, 2026 03:33
shubhamg13
marked this pull request as draft
March 18, 2026 03:33
mrobinson
previously requested changes
Mar 18, 2026
shubhamg13
marked this pull request as ready for review
July 31, 2026 09:05
shubhamg13
marked this pull request as draft
July 31, 2026 09:09
shubhamg13
marked this pull request as ready for review
July 31, 2026 09:17
shubhamg13
marked this pull request as draft
August 1, 2026 07:52
shubhamg13
marked this pull request as ready for review
August 2, 2026 03:24
jdm
requested changes
Aug 4, 2026
| self.downcast::<HTMLVideoElement>() | ||
| .expect("not a video!") | ||
| .poster_url() | ||
| } |
Member
There was a problem hiding this comment.
Instead of this method, we can add the poster URL to HTMLMediaData.
Member
Author
There was a problem hiding this comment.
Aye Aye! Added to HTMLMediaData
| Some(( | ||
| VideoInfo { | ||
| image_key: data.current_frame.map(|frame| frame.image_key), | ||
| poster_url: self.poster_url(), |
Member
There was a problem hiding this comment.
This can be data.poster_url instead.
| }, | ||
| }; | ||
|
|
||
| *self.poster_url.borrow_mut() = Some(poster_url.url()); |
Member
There was a problem hiding this comment.
We need to clear this value at the start of this method in case we take an early return. Clearing the poster URL attribute should also clear this cached value.
Member
Author
There was a problem hiding this comment.
I modified few more things to follow spec keywords. Please let me know what do you think of it.
jdm
requested changes
Aug 5, 2026
shubhamg13
marked this pull request as draft
August 5, 2026 02:56
Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
shubhamg13
marked this pull request as ready for review
August 5, 2026 03:56
jdm
reviewed
Aug 5, 2026
| { | ||
| Ok(url) => url, | ||
| Err(_) => { | ||
| let poster_url = { |
Member
There was a problem hiding this comment.
Good progress! My final suggestion here looks like this:
*self.poster_url.safe_borrow_mut(cx.no_gc()) = None;
let Some(url) = ... else { .. };
let Ok(poster_url) = match self.owner_document().encoding_parse...() else {
self.htmlmediaelement.set_poster_frame(..);
return;
};
*self.poster_url.safe_borrow_mut(cx.no_gc()) = Some(poster_url.clone());
Member
Author
There was a problem hiding this comment.
Integrated your suggestion, Please take a look
shubhamg13
marked this pull request as draft
August 5, 2026 04:23
Signed-off-by: Shubham Gupta <shubhamg13.work@gmail.com>
shubhamg13
marked this pull request as ready for review
August 5, 2026 05:42
jdm
approved these changes
Aug 5, 2026
jdm
left a comment
Member
There was a problem hiding this comment.
Looks good! Thanks for taking the time to clean it up!
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 5, 2026
Member
Author
|
Whaaaaat! I think it TIMEDOUT. Re-try Please |
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
…3376) Fetches the `poster_url` from `HTMLVideoElement` and pass it for `LargestContentfulPaint` Testing: More WPT Passed Fixes: Part of servo#42000 --------- Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org> Signed-off-by: Shubham Gupta <shubhamg13.work@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetches the
poster_urlfromHTMLVideoElementand pass it forLargestContentfulPaintTesting: More WPT Passed
Fixes: Part of #42000