Repository navigation
script: Do not load all fonts for SVG font database - #46476
Merged
Merged
Conversation
Narfinger
marked this pull request as ready for review
July 14, 2026 07:21
yezhizhen
previously requested changes
Jul 28, 2026
Narfinger
marked this pull request as draft
July 31, 2026 08:55
Narfinger
force-pushed
the
svg-font-resolver-2
branch
from
July 31, 2026 08:55
60380f8 to
c1fa8f0
Compare
Member
|
@Narfinger Is this ready for review? |
Contributor
Author
|
No there are some problems with the current design. |
Contributor
Author
|
So update after I worked a bit on it. I think I am doing something wrong with the way I matching the font families in svg_font. This website ( https://upload.wikimedia.org/wikipedia/commons/e/ea/SVG_Text_Font_Test.svg) currently looks like this: |
Narfinger
force-pushed
the
svg-font-resolver-2
branch
from
August 3, 2026 11:23
6611382 to
38caf0f
Compare
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Narfinger
force-pushed
the
svg-font-resolver-2
branch
from
August 3, 2026 11:32
38caf0f to
6f1e940
Compare
Contributor
Author
|
Ok this works now. To get feedback I am going to mark it ready for review. I am wondering if there is a better way to not put the svg_resolver into script crate but I couldn't figure it out at the moment. |
Narfinger
marked this pull request as ready for review
August 3, 2026 11:33
jdm
approved these changes
Aug 4, 2026
Co-authored-by: Josh Matthews <josh@joshmatthews.net> Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Co-authored-by: Josh Matthews <josh@joshmatthews.net> Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
jdm
approved these changes
Aug 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 6, 2026
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
Currently the SVG font database loads all system fonts at the start and also inserts any fonts it loads. This removes both of these. Additionally, we add a small cache that handles the returned fontdb::IDs if they are already entered. This will also improve the startup time of constellation (and hence everything depending on it) as we do not need to wait for all fonts to be loaded. Testing: WPT test run https://github.com/Narfinger/servo/actions/runs/30888001779 --------- Signed-off-by: Narfinger <Narfinger@users.noreply.github.com> Co-authored-by: Josh Matthews <josh@joshmatthews.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the SVG font database loads all system fonts at the start and also inserts any fonts it loads.
This removes both of these.
Additionally, we add a small cache that handles the returned fontdb::IDs if they are already entered.
This will also improve the startup time of constellation (and hence everything depending on it) as we do not need to wait for all fonts to be loaded.
Testing: WPT test run https://github.com/Narfinger/servo/actions/runs/30888001779