Repository navigation
layout: Only apply text-transform: capitalize to lowercase typographical letter units - #46910
Merged
Merged
Conversation
SimonSapin
approved these changes
Aug 3, 2026
Contributor
Can you fix the test in question so that regardless of this fix, it is no longer flaky? |
Member
Author
Yes, I'm happy to fix this test in a followup. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 17, 2026
Member
|
The failures are in |
Member
Author
After pondering this a bit, I think this isn't a timing issue at all. Instead, I think that CI is missing the fonts necessary to show the difference in this test (it uses characters like ⓐⓑⓓ). I think this is an issue like #41044. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 24, 2026
…hical letter units The specification is pretty clear that the first lowercase typographical letter unit of a word, if lowercase, should be capitalized, so this change implements that. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mrobinson
force-pushed
the
text-transform-typographical
branch
from
August 24, 2026 13:32
b1cc20e to
85183c5
Compare
mrobinson
enabled auto-merge
August 24, 2026 13:32
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
…hical letter units (servo#46910) The specification is pretty clear that the first lowercase typographical letter unit of a word, if lowercase, should be capitalized, so this change implements that. Testing: This causes text-transform-capitalize-026.html to pass locally for me. I think it's passing on CI, because CI is missing certain fonts that would otherwise make this test fail. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Psychpsyo
pushed a commit
to Psychpsyo/servo
that referenced
this pull request
Oct 12, 2026
…hical letter units (servo#46910) The specification is pretty clear that the first lowercase typographical letter unit of a word, if lowercase, should be capitalized, so this change implements that. Testing: This causes text-transform-capitalize-026.html to pass locally for me. I think it's passing on CI, because CI is missing certain fonts that would otherwise make this test fail. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specification is pretty clear that the first lowercase typographical
letter unit of a word, if lowercase, should be capitalized, so this
change implements that.
Testing: This causes text-transform-capitalize-026.html to pass locally for me.
I think it's passing on CI, because CI is missing certain fonts that would otherwise
make this test fail.