Repository navigation
script: Make performance.timing a PerformanceTiming object - #46990
Merged
Merged
Conversation
Signed-off-by: aniebietafia <aniebietafia87@gmail.com>
TimvdLippe
approved these changes
Aug 4, 2026
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
jdm
enabled auto-merge
August 4, 2026 21:44
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 4, 2026
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Member
|
But it is marked as obsolete. right? |
Member
Author
|
Still gets used by pages though! |
niyabits
pushed a commit
to niyabits/servo
that referenced
this pull request
Aug 5, 2026
…7005) Element::ensure_rare_data returns a dynamic mutable borrow, so by using safe_borrow_mut we can statically prevent multiple lurking borrow hazards. First noticed in an unexpected test failure in servo#46990. Testing: Existing test coverage suffices. Fixes: servo#47004 --------- Signed-off-by: Josh Matthews <josh@joshmatthews.net>
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
…7005) Element::ensure_rare_data returns a dynamic mutable borrow, so by using safe_borrow_mut we can statically prevent multiple lurking borrow hazards. First noticed in an unexpected test failure in servo#46990. Testing: Existing test coverage suffices. Fixes: servo#47004 --------- Signed-off-by: Josh Matthews <josh@joshmatthews.net>
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
…6990) Rebased and expanded version of servo#36441. These changes ensure the document load timing information is shared between the various interfaces that use it so we don't need to duplicate the code that marks when certain events occur. Testing: New passing tests. Fixes: servo#33334 Fixes: servo#36171 --------- Signed-off-by: aniebietafia <aniebietafia87@gmail.com> Signed-off-by: Josh Matthews <josh@joshmatthews.net> Co-authored-by: aniebietafia <aniebietafia87@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased and expanded version of #36441. These changes ensure the document load timing information is shared between the various interfaces that use it so we don't need to duplicate the code that marks when certain events occur.
Testing: New passing tests.
Fixes: #33334
Fixes: #36171