Repository navigation
constellation: Remove broken built-in sampling profiler - #47014
Merged
Merged
Conversation
As discussed [on Zulip](https://servo.zulipchat.com/#narrow/channel/263398-general/topic/Poking.20at.20the.20built-in.20sampling.20profiler/with/613859819), there's no reason to keep this maintained when better profiling solutions exist. The removal includes the code in Servo as well as the tool for converting from this profiler's output to the Firefox profiler. This includes an embedder API change, since toggling the profiler was exposed to the embedder to make the keybind work. Companion book PR will be made shortly. Signed-off-by: lumiscosity <averyrudelphe@gmail.com>
lumiscosity
force-pushed
the
remove-profiler
branch
from
August 5, 2026 09:27
cd04055 to
ba654b7
Compare
Member
|
I think |
Member
Author
Good catch, will remove that too. |
Signed-off-by: lumiscosity <averyrudelphe@gmail.com>
lumiscosity
added a commit
to lumiscosity/book
that referenced
this pull request
Aug 5, 2026
Companion to servo/servo#47014. ALso contains a minor wording tweak. Signed-off-by: lumiscosity <averyrudelphe@gmail.com>
jschwe
approved these changes
Aug 5, 2026
Signed-off-by: lumiscosity <averyrudelphe@gmail.com>
Signed-off-by: lumiscosity <averyrudelphe@gmail.com>
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
As discussed [on Zulip](https://servo.zulipchat.com/#narrow/channel/263398-general/topic/Poking.20at.20the.20built-in.20sampling.20profiler/with/613859819), there's no reason to keep this maintained when better profiling solutions exist. The removal includes the code in Servo as well as the tool for converting from this profiler's output to the Firefox profiler. This includes an embedder API change, since toggling the profiler was exposed to the embedder to make the keybind work. Companion book PR will be made shortly. Testing: Manual - it compiles and Ctrl+P no longer does anything --------- Signed-off-by: lumiscosity <averyrudelphe@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Zulip, there's no reason to keep this maintained when better profiling solutions exist. The removal includes the code in Servo as well as the tool for converting from this profiler's output to the Firefox profiler.
This includes an embedder API change, since toggling the profiler was exposed to the embedder to make the keybind work.
Companion book PR will be made shortly.
Testing: Manual - it compiles and Ctrl+P no longer does anything