Skip to content

script: Pass the prefix from the parser when creating attributes - #47030

Merged
jdm merged 2 commits into
servo:mainfrom
Ms2ger:parser-prefix
Aug 6, 2026
Merged

jdm merged 2 commits into
servo:mainfrom
Ms2ger:parser-prefix

Conversation

@Ms2ger

@Ms2ger Ms2ger commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #46868: now passing the correct prefix and qualified name when creating elements from the parser.

Testing: WPTs now pass.

Follow-up to servo#46868: now passing the correct prefix and qualified name when creating elements from the parser.

Testing: WPTs now pass.

Signed-off-by: Ms2ger <Ms2ger@gmail.com>
@Ms2ger
Ms2ger requested a review from gterzian as a code owner August 5, 2026 21:38
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 5, 2026

@TimvdLippe TimvdLippe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Aug 6, 2026
@TimvdLippe
TimvdLippe added this pull request to the merge queue Aug 6, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 6, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 6, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 6, 2026

@yezhizhen yezhizhen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/servo/servo/runs/92530233475

There are more passing tests we should update.

@TimvdLippe

Copy link
Copy Markdown
Contributor

You can do so by running ./mach update-wpt https://github.com/servo/servo/runs/92530233475

Signed-off-by: Ms2ger <Ms2ger@gmail.com>
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 6, 2026
@jdm
jdm added this pull request to the merge queue Aug 6, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 6, 2026
Merged via the queue into servo:main with commit dda6e3d Aug 6, 2026
36 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 6, 2026
@Ms2ger
Ms2ger deleted the parser-prefix branch August 7, 2026 09:20
RichardTjokroutomo pushed a commit to RichardTjokroutomo/servo that referenced this pull request Oct 6, 2026
…vo#47030)

Follow-up to servo#46868: now passing the correct prefix and qualified name
when creating elements from the parser.

Testing: WPTs now pass.

---------

Signed-off-by: Ms2ger <Ms2ger@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants