Repository navigation
css: Implement touch-action (Except for pan-{up,down,left,right} that Stylo does not support) - #47043
Conversation
There was a problem hiding this comment.
The implementation is based on test expectation in
Btw, firefox itself also does not suppot parsing direcitonal value (pan-{up, down...}):
| /// scroll. | ||
| /// This node can be scrolled by mouse wheel or other non-touch input events, or | ||
| /// such an input event originated this scroll. | ||
| const InputEvents = 1 << 0; |
There was a problem hiding this comment.
The naming is a bit awkward. I am not sure about NonTouchInputEvents ..
| viewport_details.layout_size(), | ||
| ), | ||
| scroll_sensitivity: viewport_scroll_sensitivity, | ||
| touch_action: TouchAction::Auto, |
There was a problem hiding this comment.
We are hard coding this only in viewport scroll node in PaintDisplayListInfo::new. As style is not determined yet.
touch-action (Except for pan-{up,down,left,right} that Stylo does not support)touch-action (Except for pan-{up,down,left,right} that Stylo does not support)
|
🔨 Triggering try run (#31309574014) for Linux (WPT) |
|
Test results for linux-wpt from try job (#31309574014): Flaky unexpected result (40)
Stable unexpected results that are known to be intermittent (16)
|
|
✨ Try run (#31309574014) succeeded. |
|
@mrobinson Pls help review. |
Narfinger
left a comment
There was a problem hiding this comment.
Just some small nits but somebody else might want to look at it.
|
🔨 Triggering try run (#32731414779) for Linux (WPT) |
|
Test results for linux-wpt from try job (#32731414779): Flaky unexpected result (40)
Stable unexpected results that are known to be intermittent (18)
|
|
✨ Try run (#32731414779) succeeded. |
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Servo PR: servo/servo#47043 Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
…ervo#47890) Updated 9 more tests in similar fashion to web-platform-tests/wpt#62498. I missed these in first patch as I was only focusing on [try run here](https://github.com/servo/servo/actions/runs/33942192665). Testing: Safari and Servo no longer WebDriver out of bound, and checked in Firefox under 800x600. Updated expectations. Some new passing is due to servo#47043 earlier. Fixes: web-platform-tests/wpt#62481 --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
…at Stylo does not support) (servo#47043) Motivated by servo#46983 to get this to the end. This has 44.1736% usage percentage as listed in Chrome report, and controls the most basic interaction rule with touch. Stylo PR: servo/stylo#439 Testing: Only new passing. No new failure. All of them are pointerevents tests so demonstrate quite the value. --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
…ervo#47890) Updated 9 more tests in similar fashion to web-platform-tests/wpt#62498. I missed these in first patch as I was only focusing on [try run here](https://github.com/servo/servo/actions/runs/33942192665). Testing: Safari and Servo no longer WebDriver out of bound, and checked in Firefox under 800x600. Updated expectations. Some new passing is due to servo#47043 earlier. Fixes: web-platform-tests/wpt#62481 --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
…at Stylo does not support) (servo#47043) Motivated by servo#46983 to get this to the end. This has 44.1736% usage percentage as listed in Chrome report, and controls the most basic interaction rule with touch. Stylo PR: servo/stylo#439 Testing: Only new passing. No new failure. All of them are pointerevents tests so demonstrate quite the value. --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Motivated by #46983 to get this to the end.
This has 44.1736% usage percentage as listed in Chrome report, and controls the most basic interaction rule with touch.
Stylo PR: servo/stylo#439
Testing: Only new passing. No new failure. All of them are pointerevents tests so demonstrate quite the value.