Repository navigation
script: Fix GC borrow hazard in HTMLImageElement::abort_request - #47051
Merged
Merged
Conversation
jdm
reviewed
Aug 6, 2026
treetmitterglad
force-pushed
the
abort_request-borrow-hazard
branch
from
August 6, 2026 20:33
74950f6 to
bdbd3c8
Compare
jdm
enabled auto-merge
August 6, 2026 21:04
Narfinger
force-pushed
the
abort_request-borrow-hazard
branch
from
August 7, 2026 07:38
bdbd3c8 to
006b4d7
Compare
Contributor
|
Rebased to restart CI. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Aug 7, 2026
Signed-off-by: Eli Bowman <asdfup@protonmail.com>
treetmitterglad
force-pushed
the
abort_request-borrow-hazard
branch
from
August 7, 2026 19:31
006b4d7 to
06f767e
Compare
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
…o#47051) Rewrote GC handling in the `abort_request` function to prevent potential crashes due to conflicts with the GC during mutable borrows, and to perform immutable borrows when possible. Testing: Ran `./mach test-wpt tests/wpt/tests/html/semantics/embedded-content/the-img-element/ `, 135/135 passed Fixes: servo#34107 Signed-off-by: Eli Bowman <asdfup@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote GC handling in the
abort_requestfunction to prevent potential crashes due to conflicts with the GC during mutable borrows, and to perform immutable borrows when possible.Testing: Ran
./mach test-wpt tests/wpt/tests/html/semantics/embedded-content/the-img-element/, 135/135 passedFixes: #34107