Skip to content

android / ohos: Respect device_pixel_ratio_override in servoshell - #47081

Merged
yezhizhen merged 1 commit into
servo:mainfrom
jschwe:respect_dpr_override
Aug 9, 2026
Merged

yezhizhen merged 1 commit into
servo:mainfrom
jschwe:respect_dpr_override

Conversation

@jschwe

@jschwe jschwe commented Aug 8, 2026

Copy link
Copy Markdown
Member

If the servoshell preference is set, it should be respected instead of ignored.
Desktop already respected this preference.

Testing: Not tested.

Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 8, 2026
@yezhizhen yezhizhen changed the title android / ohos: Respect device_pixel_override in servoshell android / ohos: Respect device_pixel_ratio_override in servoshell Aug 9, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Aug 9, 2026
@yezhizhen
yezhizhen added this pull request to the merge queue Aug 9, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 9, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 9, 2026
@yezhizhen
yezhizhen added this pull request to the merge queue Aug 9, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 9, 2026
Merged via the queue into servo:main with commit e2bcea2 Aug 9, 2026
43 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 9, 2026
@jschwe
jschwe deleted the respect_dpr_override branch August 9, 2026 05:50
viewport_rect,
hidpi_factor,
Some(ServoShellWindowId::from(
NEXT_WINDOW_ID.load(std::sync::atomic::Ordering::SeqCst),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course

RichardTjokroutomo pushed a commit to RichardTjokroutomo/servo that referenced this pull request Oct 6, 2026
…ervo#47081)

If the servoshell preference is set, it should be respected instead of
ignored.
Desktop already respected this preference.

Testing: Not tested.

Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants